public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: [PATCH kvmtool 3/6] Makefile: support -s switch
Date: Fri, 25 Jan 2019 18:07:58 +0000	[thread overview]
Message-ID: <20190125180801.209910-4-andre.przywara@arm.com> (raw)
In-Reply-To: <20190125180801.209910-1-andre.przywara@arm.com>

"make -s" suppresses normal output, just shows warnings and errors.
But since we explicitly override the make output with our fancy concise
version, we miss out on this feature.

Do as the kernel does and explicitly suppress every normal output when -s
is given. This helps to spot warnings that scroll out of the terminal
window too quickly.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 Makefile | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index c4faff66..a68cfcd5 100644
--- a/Makefile
+++ b/Makefile
@@ -2,8 +2,22 @@
 # Define WERROR=0 to disable -Werror.
 #
 
+ifneq ($(filter 4.%,$(MAKE_VERSION)),)  # make-4
+ifneq ($(filter %s ,$(firstword x$(MAKEFLAGS))),)
+  silent=1
+endif
+else                                    # make-3.8x
+ifneq ($(filter s% -s%,$(MAKEFLAGS)),)
+  silent=1
+endif
+endif
+
 ifeq ($(strip $(V)),)
-	E = @echo
+	ifeq ($(silent),)
+		E = @echo
+	else
+		E = @\#
+	endif
 	Q = @
 else
 	E = @\#
-- 
2.17.1

  parent reply	other threads:[~2019-01-25 18:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 18:07 [PATCH kvmtool 0/6] Various convenience fixes Andre Przywara
2019-01-25 18:07 ` [PATCH kvmtool 1/6] arm: turn pr_info() into pr_debug() messages Andre Przywara
2019-01-25 18:07 ` [PATCH kvmtool 2/6] arm: fdt: add stdout-path to /chosen node Andre Przywara
2019-01-30 18:20   ` Will Deacon
2019-01-31 14:57     ` Andre Przywara
2019-02-01  6:26       ` Will Deacon
2019-02-01 11:03         ` Andre Przywara
2019-01-25 18:07 ` Andre Przywara [this message]
2019-01-30 18:20   ` [PATCH kvmtool 3/6] Makefile: support -s switch Will Deacon
2019-01-31 13:48     ` Andre Przywara
2019-01-25 18:07 ` [PATCH kvmtool 4/6] Makefile: Remove echoing of kvmtools version file Andre Przywara
2019-01-30 18:20   ` Will Deacon
2019-01-31 18:36     ` Andre Przywara
2019-01-25 18:08 ` [PATCH kvmtool 5/6] arm: pmu: Improve PMU error reporting Andre Przywara
2019-01-25 18:08 ` [PATCH kvmtool 6/6] arm: Auto-detect guest GIC type Andre Przywara
2019-01-30 18:20   ` Will Deacon
2019-01-31 18:46     ` Andre Przywara
2019-01-30 18:20 ` [PATCH kvmtool 0/6] Various convenience fixes Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190125180801.209910-4-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox