From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net-next V4 0/5] vhost: accelerate metadata access through vmap() Date: Sat, 26 Jan 2019 19:31:38 -0500 Message-ID: <20190126193126-mutt-send-email-mst@kernel.org> References: <20190123095557.30168-1-jasowang@redhat.com> <20190126.143708.1203048880266877709.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <20190126.143708.1203048880266877709.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Sat, Jan 26, 2019 at 02:37:08PM -0800, David Miller wrote: > From: Jason Wang > Date: Wed, 23 Jan 2019 17:55:52 +0800 > > > This series tries to access virtqueue metadata through kernel virtual > > address instead of copy_user() friends since they had too much > > overheads like checks, spec barriers or even hardware feature > > toggling. > > > > Test shows about 24% improvement on TX PPS. It should benefit other > > cases as well. > > I've read over the discussion of patch #5 a few times. > > And it seems to me that, at a minimum, a few things still need to > be resolved: > > 1) More perf data added to commit message. > > 2) Whether invalidate_range_start() and invalidate_range_end() must > be paired. Add dirty tracking. > Etc. So I am marking this series "Changes Requested".