From: Will Deacon <will.deacon@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: [PATCH kvmtool] arm: Allow command line for firmware
Date: Wed, 30 Jan 2019 18:20:10 +0000 [thread overview]
Message-ID: <20190130182010.GE18558@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190125154308.185131-1-andre.przywara@arm.com>
On Fri, Jan 25, 2019 at 03:43:08PM +0000, Andre Przywara wrote:
> When loading a firmware instead of a kernel, we can still pass on any
> *user-provided* command line, as /chosen/bootargs is a generic device tree
> feature. We just need to make sure to not pass our mangled-for-Linux
> version.
>
> This allows to run "firmware" images which make use of a command line,
> still are not Linux kernels, like kvm-unit-tests.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Hi Will,
>
> this goes on top of Julien's firmware series (which did not yet appear
> on kernel.org?)
> This fixes an issue with some kvm-unit-tests support. [1]
Does kvm-unit-tests break if we pass the modified command line? I'm wary of
passing something different depending on whether the payload is firmware or
kernel, because there's a pretty fine line between the two (and the firmware
may even just forward the thing on to the kernel it loads).
Will
next prev parent reply other threads:[~2019-01-30 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 15:43 [PATCH kvmtool] arm: Allow command line for firmware Andre Przywara
2019-01-30 18:20 ` Will Deacon [this message]
2019-01-31 13:07 ` Andrew Jones
2019-01-31 13:48 ` Andre Przywara
2019-01-31 13:40 ` Julien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130182010.GE18558@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox