From: Will Deacon <will.deacon@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: [PATCH kvmtool 4/6] Makefile: Remove echoing of kvmtools version file
Date: Wed, 30 Jan 2019 18:20:36 +0000 [thread overview]
Message-ID: <20190130182036.GH18558@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190125180801.209910-5-andre.przywara@arm.com>
On Fri, Jan 25, 2019 at 06:07:59PM +0000, Andre Przywara wrote:
> On every build we report the kvmtool "version" number, which isn't
> meaningful at all anymore.
>
> Remove the line from the KVMTOOLS-VERSION-GEN script to drop a
> pointless message.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> util/KVMTOOLS-VERSION-GEN | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/util/KVMTOOLS-VERSION-GEN b/util/KVMTOOLS-VERSION-GEN
> index f0dcfdea..91ee2c2f 100755
> --- a/util/KVMTOOLS-VERSION-GEN
> +++ b/util/KVMTOOLS-VERSION-GEN
> @@ -35,6 +35,5 @@ else
> VC=unset
> fi
> test "$VN" = "$VC" || {
> - echo >&2 "KVMTOOLS_VERSION = $VN"
> echo "KVMTOOLS_VERSION = $VN" >$GVF
It's probably fine, but can you check this doesn't break the debian
packaging please?
Will
next prev parent reply other threads:[~2019-01-30 18:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 18:07 [PATCH kvmtool 0/6] Various convenience fixes Andre Przywara
2019-01-25 18:07 ` [PATCH kvmtool 1/6] arm: turn pr_info() into pr_debug() messages Andre Przywara
2019-01-25 18:07 ` [PATCH kvmtool 2/6] arm: fdt: add stdout-path to /chosen node Andre Przywara
2019-01-30 18:20 ` Will Deacon
2019-01-31 14:57 ` Andre Przywara
2019-02-01 6:26 ` Will Deacon
2019-02-01 11:03 ` Andre Przywara
2019-01-25 18:07 ` [PATCH kvmtool 3/6] Makefile: support -s switch Andre Przywara
2019-01-30 18:20 ` Will Deacon
2019-01-31 13:48 ` Andre Przywara
2019-01-25 18:07 ` [PATCH kvmtool 4/6] Makefile: Remove echoing of kvmtools version file Andre Przywara
2019-01-30 18:20 ` Will Deacon [this message]
2019-01-31 18:36 ` Andre Przywara
2019-01-25 18:08 ` [PATCH kvmtool 5/6] arm: pmu: Improve PMU error reporting Andre Przywara
2019-01-25 18:08 ` [PATCH kvmtool 6/6] arm: Auto-detect guest GIC type Andre Przywara
2019-01-30 18:20 ` Will Deacon
2019-01-31 18:46 ` Andre Przywara
2019-01-30 18:20 ` [PATCH kvmtool 0/6] Various convenience fixes Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130182036.GH18558@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox