From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH kvmtool 4/6] Makefile: Remove echoing of kvmtools version file Date: Wed, 30 Jan 2019 18:20:36 +0000 Message-ID: <20190130182036.GH18558@fuggles.cambridge.arm.com> References: <20190125180801.209910-1-andre.przywara@arm.com> <20190125180801.209910-5-andre.przywara@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org To: Andre Przywara Return-path: Content-Disposition: inline In-Reply-To: <20190125180801.209910-5-andre.przywara@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On Fri, Jan 25, 2019 at 06:07:59PM +0000, Andre Przywara wrote: > On every build we report the kvmtool "version" number, which isn't > meaningful at all anymore. > > Remove the line from the KVMTOOLS-VERSION-GEN script to drop a > pointless message. > > Signed-off-by: Andre Przywara > --- > util/KVMTOOLS-VERSION-GEN | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/KVMTOOLS-VERSION-GEN b/util/KVMTOOLS-VERSION-GEN > index f0dcfdea..91ee2c2f 100755 > --- a/util/KVMTOOLS-VERSION-GEN > +++ b/util/KVMTOOLS-VERSION-GEN > @@ -35,6 +35,5 @@ else > VC=unset > fi > test "$VN" = "$VC" || { > - echo >&2 "KVMTOOLS_VERSION = $VN" > echo "KVMTOOLS_VERSION = $VN" >$GVF It's probably fine, but can you check this doesn't break the debian packaging please? Will