From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC][Patch v8 6/7] KVM: Enables the kernel to isolate and report free pages Date: Fri, 8 Feb 2019 16:38:09 -0500 Message-ID: <20190208163601-mutt-send-email-mst@kernel.org> References: <20190204201854.2328-1-nitesh@redhat.com> <20190204201854.2328-7-nitesh@redhat.com> <20190205153607-mutt-send-email-mst@kernel.org> <20190205165514-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Duyck , kvm list , LKML , Paolo Bonzini , lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, Yang Zhang , Rik van Riel , david@redhat.com, dodgen@google.com, Konrad Rzeszutek Wilk , dhildenb@redhat.com, Andrea Arcangeli To: Nitesh Narayan Lal Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Fri, Feb 08, 2019 at 03:41:55PM -0500, Nitesh Narayan Lal wrote: > >> I am also planning to try Michael's suggestion of using MAX_ORDER - 1. > >> However I am still thinking about a workload which I can use to test its > >> effectiveness. > > You might want to look at doing something like min(MAX_ORDER - 1, > > HUGETLB_PAGE_ORDER). I know for x86 a 2MB page is the upper limit for > > THP which is the most likely to be used page size with the guest. > Sure, thanks for the suggestion. Given current hinting in balloon is MAX_ORDER I'd say share code. If you feel a need to adjust down the road, adjust both of them with actual testing showing gains. -- MST