From mboxrd@z Thu Jan  1 00:00:00 1970
From: Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 09/22] x86/fpu: Add (__)make_fpregs_active helpers
Date: Wed, 13 Feb 2019 10:30:25 +0100
Message-ID: <20190213093025.GA9683@zn.tnic>
References: <20190109114744.10936-1-bigeasy@linutronix.de>
 <20190109114744.10936-10-bigeasy@linutronix.de>
 <20190128182349.GG20487@zn.tnic>
 <20190207104325.ai5fzaxa7xy7yydv@linutronix.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        kvm@vger.kernel.org, "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Rik van Riel <riel@surriel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20190207104325.ai5fzaxa7xy7yydv@linutronix.de>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Thu, Feb 07, 2019 at 11:43:25AM +0100, Sebastian Andrzej Siewior wrote:
> They are accessible inside the region. But they should not be touched by
> context switch code (and later BH).
> Is that what you meant?

I just don't like that "changes" name. So when called, those functions
practically lock the FPU regs from being accessed by others. So with

fpregs_lock
fpregs_unlock

for example, is kinda clear what's going on and you don't have to wonder
what it does.

> No. I picked up the patches, that function was named like that. I kept
> it. That __ probably denotes that it is an internal function but then it
> has to be used outside (KVM) if they plan to "reload" registers (which
> happens if they switch between host/guest registers).

Ok, so you can drop the "__".

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.