* [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT
@ 2019-02-22 10:48 lantianyu1986
2019-02-22 14:32 ` Greg KH
2019-03-15 17:45 ` Paolo Bonzini
0 siblings, 2 replies; 5+ messages in thread
From: lantianyu1986 @ 2019-02-22 10:48 UTC (permalink / raw)
Cc: Lan Tianyu, kys, haiyangz, sthemmin, sashal, tglx, mingo, bp, hpa,
x86, pbonzini, rkrcmar, devel, linux-kernel, kvm,
michael.h.kelley, vkuznets, stable
From: Lan Tianyu <Tianyu.Lan@microsoft.com>
The max flush rep count of HvFlushGuestPhysicalAddressList hypercall
is equal with how many entries of union hv_gpa_page_range can be populated
into the input parameter page. The origin code lacks parenthesis around
PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it.
Cc: <stable@vger.kernel.org>
Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support)
Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
---
arch/x86/include/asm/hyperv-tlfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h
index 705dafc2d11a..2bdbbbcfa393 100644
--- a/arch/x86/include/asm/hyperv-tlfs.h
+++ b/arch/x86/include/asm/hyperv-tlfs.h
@@ -841,7 +841,7 @@ union hv_gpa_page_range {
* count is equal with how many entries of union hv_gpa_page_range can
* be populated into the input parameter page.
*/
-#define HV_MAX_FLUSH_REP_COUNT (PAGE_SIZE - 2 * sizeof(u64) / \
+#define HV_MAX_FLUSH_REP_COUNT ((PAGE_SIZE - 2 * sizeof(u64)) / \
sizeof(union hv_gpa_page_range))
struct hv_guest_mapping_flush_list {
--
2.14.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT
2019-02-22 10:48 [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT lantianyu1986
@ 2019-02-22 14:32 ` Greg KH
2019-02-23 14:35 ` Tianyu Lan
2019-03-15 17:45 ` Paolo Bonzini
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-02-22 14:32 UTC (permalink / raw)
To: lantianyu1986
Cc: Lan Tianyu, kys, haiyangz, sthemmin, sashal, tglx, mingo, bp, hpa,
x86, pbonzini, rkrcmar, devel, linux-kernel, kvm,
michael.h.kelley, vkuznets, stable
On Fri, Feb 22, 2019 at 06:48:44PM +0800, lantianyu1986@gmail.com wrote:
> From: Lan Tianyu <Tianyu.Lan@microsoft.com>
>
> The max flush rep count of HvFlushGuestPhysicalAddressList hypercall
> is equal with how many entries of union hv_gpa_page_range can be populated
> into the input parameter page. The origin code lacks parenthesis around
> PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it.
>
> Cc: <stable@vger.kernel.org>
> Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support)
Please use this format instead:
Fixes: cc4edae4b924 ("x86/hyper-v: Add HvFlushGuestAddressList hypercall support")
And don't type it by hand, use a git alias for it:
git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
You also messed up your To: line, keeping anyone from being able to
respond to this message who do not know how to hand-edit the response
line :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT
2019-02-22 14:32 ` Greg KH
@ 2019-02-23 14:35 ` Tianyu Lan
0 siblings, 0 replies; 5+ messages in thread
From: Tianyu Lan @ 2019-02-23 14:35 UTC (permalink / raw)
To: Greg KH
Cc: Lan Tianyu, kys, haiyangz, sthemmin, Sasha Levin, Thomas Gleixner,
Ingo Molnar, bp, H. Peter Anvin, the arch/x86 maintainers,
Paolo Bonzini, Radim Krcmar, devel, linux-kernel@vger kernel org,
kvm, michael.h.kelley, Vitaly Kuznetsov, stable
On Fri, Feb 22, 2019 at 10:32 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Feb 22, 2019 at 06:48:44PM +0800, lantianyu1986@gmail.com wrote:
> > From: Lan Tianyu <Tianyu.Lan@microsoft.com>
> >
> > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall
> > is equal with how many entries of union hv_gpa_page_range can be populated
> > into the input parameter page. The origin code lacks parenthesis around
> > PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it.
> >
> > Cc: <stable@vger.kernel.org>
> > Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support)
>
> Please use this format instead:
>
> Fixes: cc4edae4b924 ("x86/hyper-v: Add HvFlushGuestAddressList hypercall support")
>
> And don't type it by hand, use a git alias for it:
> git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
>
OK. Will update. Thanks.
> You also messed up your To: line, keeping anyone from being able to
> respond to this message who do not know how to hand-edit the response
> line :(
I put all expected reviewers in the Cc line and will put into To line.
>
> thanks,
>
> greg k-h
--
Best regards
Tianyu Lan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT
2019-02-22 10:48 [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT lantianyu1986
2019-02-22 14:32 ` Greg KH
@ 2019-03-15 17:45 ` Paolo Bonzini
2019-03-20 8:29 ` Thomas Gleixner
1 sibling, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2019-03-15 17:45 UTC (permalink / raw)
To: lantianyu1986
Cc: Lan Tianyu, kys, haiyangz, sthemmin, sashal, tglx, mingo, bp, hpa,
x86, rkrcmar, devel, linux-kernel, kvm, michael.h.kelley,
vkuznets, stable
On 22/02/19 11:48, lantianyu1986@gmail.com wrote:
> From: Lan Tianyu <Tianyu.Lan@microsoft.com>
>
> The max flush rep count of HvFlushGuestPhysicalAddressList hypercall
> is equal with how many entries of union hv_gpa_page_range can be populated
> into the input parameter page. The origin code lacks parenthesis around
> PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it.
>
> Cc: <stable@vger.kernel.org>
> Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support)
> Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
> ---
> arch/x86/include/asm/hyperv-tlfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h
> index 705dafc2d11a..2bdbbbcfa393 100644
> --- a/arch/x86/include/asm/hyperv-tlfs.h
> +++ b/arch/x86/include/asm/hyperv-tlfs.h
> @@ -841,7 +841,7 @@ union hv_gpa_page_range {
> * count is equal with how many entries of union hv_gpa_page_range can
> * be populated into the input parameter page.
> */
> -#define HV_MAX_FLUSH_REP_COUNT (PAGE_SIZE - 2 * sizeof(u64) / \
> +#define HV_MAX_FLUSH_REP_COUNT ((PAGE_SIZE - 2 * sizeof(u64)) / \
> sizeof(union hv_gpa_page_range))
>
> struct hv_guest_mapping_flush_list {
>
Queued for after he merge window, with the fixed "Fixes" tag.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT
2019-03-15 17:45 ` Paolo Bonzini
@ 2019-03-20 8:29 ` Thomas Gleixner
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Gleixner @ 2019-03-20 8:29 UTC (permalink / raw)
To: Paolo Bonzini
Cc: lantianyu1986, Lan Tianyu, kys, haiyangz, sthemmin, sashal, mingo,
bp, hpa, x86, rkrcmar, devel, linux-kernel, kvm, michael.h.kelley,
vkuznets, stable
On Fri, 15 Mar 2019, Paolo Bonzini wrote:
> On 22/02/19 11:48, lantianyu1986@gmail.com wrote:
> > From: Lan Tianyu <Tianyu.Lan@microsoft.com>
> >
> > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall
> > is equal with how many entries of union hv_gpa_page_range can be populated
> > into the input parameter page. The origin code lacks parenthesis around
> > PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it.
> >
> > Cc: <stable@vger.kernel.org>
> > Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support)
> > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com>
> > ---
> > arch/x86/include/asm/hyperv-tlfs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h
> > index 705dafc2d11a..2bdbbbcfa393 100644
> > --- a/arch/x86/include/asm/hyperv-tlfs.h
> > +++ b/arch/x86/include/asm/hyperv-tlfs.h
> > @@ -841,7 +841,7 @@ union hv_gpa_page_range {
> > * count is equal with how many entries of union hv_gpa_page_range can
> > * be populated into the input parameter page.
> > */
> > -#define HV_MAX_FLUSH_REP_COUNT (PAGE_SIZE - 2 * sizeof(u64) / \
> > +#define HV_MAX_FLUSH_REP_COUNT ((PAGE_SIZE - 2 * sizeof(u64)) / \
> > sizeof(union hv_gpa_page_range))
> >
> > struct hv_guest_mapping_flush_list {
> >
>
> Queued for after he merge window, with the fixed "Fixes" tag.
That's upstream already:
9cd05ad2910b ("x86/hyper-v: Fix definition of HV_MAX_FLUSH_REP_COUNT")
Thanks,
tglx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-20 8:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-22 10:48 [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT lantianyu1986
2019-02-22 14:32 ` Greg KH
2019-02-23 14:35 ` Tianyu Lan
2019-03-15 17:45 ` Paolo Bonzini
2019-03-20 8:29 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox