From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v4 03/17] wlcore: Align reg_ch_conf_pending and
 tmp_ch_bitmap to unsigned long for better performance
Date: Mon, 4 Mar 2019 14:30:17 +0100
Message-ID: <20190304133017.GL32494@hirez.programming.kicks-ass.net>
References: <1551494711-213533-1-git-send-email-fenghua.yu@intel.com>
 <1551494711-213533-4-git-send-email-fenghua.yu@intel.com>
 <20190304101141.GB32477@hirez.programming.kicks-ass.net>
 <44bb6771-7aea-c44d-6605-45e7a1499d1b@redhat.com>
 <20190304124144.GD32477@hirez.programming.kicks-ass.net>
 <9f334d1e-491f-565e-02fc-1a769e4f1b79@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Ashok Raj <ashok.raj@intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Xiaoyao Li <xiaoyao.li@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        x86 <x86@kernel.org>, kvm@vger.kernel.org
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <9f334d1e-491f-565e-02fc-1a769e4f1b79@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Mon, Mar 04, 2019 at 02:09:30PM +0100, Paolo Bonzini wrote:
> >> @@ -1700,14 +1700,14 @@ void wlcore_set_pending_regdomain_ch(struct wl1271 *wl, u16 channel,
> >>  	ch_bit_idx = wlcore_get_reg_conf_ch_idx(band, channel);
> >>  
> >>  	if (ch_bit_idx >= 0 && ch_bit_idx <= WL1271_MAX_CHANNELS)
> >> -		set_bit(ch_bit_idx, (long *)wl->reg_ch_conf_pending);
> >> +		__set_bit_le(ch_bit_idx, (long *)wl->reg_ch_conf_pending);
> >>  }
> >>  

> I've used __set_bit_le when setting reg_ch_conf_pending so no need to
> swizzle here; 

Argh, reading hard. Yes, then it all works.