Re: [PATCH v4 03/17] wlcore: Align reg_ch_conf_pending and tmp_ch_bitmap to unsigned long for better performance

Peter Zijlstra
2019-03-04T13:30:17Z

On Mon, Mar 04, 2019 at 02:09:30PM +0100, Paolo Bonzini wrote:
> >> @@ -1700,14 +1700,14 @@ void wlcore_set_pending_regdomain_ch(struct wl1271 *wl, u16 channel,
> >> ch_bit_idx = wlcore_get_reg_conf_ch_idx(band, channel);
> >>
> >> if (ch_bit_idx >= 0 && ch_bit_idx <= WL1271_MAX_CHANNELS)
> >> - set_bit(ch_bit_idx, (long *)wl->reg_ch_conf_pending);
> >> + __set_bit_le(ch_bit_idx, (long *)wl->reg_ch_conf_pending);
> >> }
> >>

> I've used __set_bit_le when setting reg_ch_conf_pending so no need to
> swizzle here;

Argh, reading hard. Yes, then it all works.