From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC][Patch v9 0/6] KVM: Guest Free Page Hinting Date: Wed, 6 Mar 2019 13:38:15 -0500 Message-ID: <20190306133613-mutt-send-email-mst@kernel.org> References: <20190306155048.12868-1-nitesh@redhat.com> <20190306110501-mutt-send-email-mst@kernel.org> <20190306130955-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, yang.zhang.wz@gmail.com, riel@surriel.com, david@redhat.com, dodgen@google.com, konrad.wilk@oracle.com, dhildenb@redhat.com, aarcange@redhat.com, alexander.duyck@gmail.com To: Nitesh Narayan Lal Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Mar 06, 2019 at 01:30:14PM -0500, Nitesh Narayan Lal wrote: > > Want to try testing Alex's patches for comparison? > Somehow I am not in a favor of doing a hypercall on every page (with > huge TLB order/MAX_ORDER -1) as I think it will be costly. > I can try using Alex's host side logic instead of virtio. > Let me know what you think? I am just saying maybe your setup is misconfigured that's why you see no speedup. If you try Alex's patches and *don't* see speedup like he does, then he might be able to help you figure out why. OTOH if you do then *you* can try figuring out why don't your patches help. -- MST