From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCHv1 1/7] vfio/mdev: Avoid release parent reference during error path Date: Mon, 1 Apr 2019 18:58:47 +0200 Message-ID: <20190401185847.0e45cad7.cohuck@redhat.com> References: <1553658345-43995-1-git-send-email-parav@mellanox.com> <1553658345-43995-2-git-send-email-parav@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kwankhede@nvidia.com, alex.williamson@redhat.com, cjia@nvidia.com To: Parav Pandit Return-path: In-Reply-To: <1553658345-43995-2-git-send-email-parav@mellanox.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, 26 Mar 2019 22:45:39 -0500 Parav Pandit wrote: > During mdev parent registration in mdev_register_device(), > if parent device is duplicate, it releases the reference of existing > parent device. > This is incorrect. Existing parent device should not be touched. > > Fixes: 7b96953bc640 ("vfio: Mediated device Core driver") > Reviewed By: Kirti Wankhede Should probably be changed to the canonical Reviewed-by:. > Reviewed-by: Maxim Levitsky > Signed-off-by: Parav Pandit > --- > drivers/vfio/mdev/mdev_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index b96fedc..1299d2e 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -181,6 +181,7 @@ int mdev_register_device(struct device *dev, const struct mdev_parent_ops *ops) > /* Check for duplicate */ > parent = __find_parent_device(dev); > if (parent) { > + parent = NULL; > ret = -EEXIST; > goto add_dev_err; > } Reviewed-by: Cornelia Huck