From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCHv1 4/7] vfio/mdev: Avoid masking error code to EBUSY Date: Mon, 1 Apr 2019 19:21:15 +0200 Message-ID: <20190401192115.3bc7ec4e.cohuck@redhat.com> References: <1553658345-43995-1-git-send-email-parav@mellanox.com> <1553658345-43995-5-git-send-email-parav@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kwankhede@nvidia.com, alex.williamson@redhat.com, cjia@nvidia.com To: Parav Pandit Return-path: In-Reply-To: <1553658345-43995-5-git-send-email-parav@mellanox.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, 26 Mar 2019 22:45:42 -0500 Parav Pandit wrote: > Instead of masking return error to -EBUSY, return actual error > returned by the driver. > > Reviewed-by: Maxim Levitsky > Signed-off-by: Parav Pandit > --- > drivers/vfio/mdev/mdev_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 00ca613..836d319 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -141,7 +141,7 @@ static int mdev_device_remove_ops(struct mdev_device *mdev, bool force_remove) > */ > ret = parent->ops->remove(mdev); > if (ret && !force_remove) > - return -EBUSY; > + return ret; > > sysfs_remove_groups(&mdev->dev.kobj, parent->ops->mdev_attr_groups); > return 0; Makes sense, even if no current ->remove callback returns anything other than 0 or -EBUSY. Reviewed-by: Cornelia Huck