From: Alex Williamson <alex.williamson@redhat.com>
To: Wang Hai <wanghai26@huawei.com>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static
Date: Wed, 3 Apr 2019 12:52:22 -0600 [thread overview]
Message-ID: <20190403125222.021d0908@x1.home> (raw)
In-Reply-To: <20190320064723.46604-1-wanghai26@huawei.com>
On Wed, 20 Mar 2019 02:47:23 -0400
Wang Hai <wanghai26@huawei.com> wrote:
> Fixes the following sparse warning:
>
> drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning:
> symbol 'tce_iommu_driver_ops' was not declared. Should it be static?
>
> Fixes: 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO")
> Signed-off-by: Wang Hai <wanghai26@huawei.com>
> ---
Applied to vfio for-linus branch for v5.1 with Alexey's R-b. Thanks!
Alex
> drivers/vfio/vfio_iommu_spapr_tce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
> index 8dbb270..6b64e45 100644
> --- a/drivers/vfio/vfio_iommu_spapr_tce.c
> +++ b/drivers/vfio/vfio_iommu_spapr_tce.c
> @@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data,
> mutex_unlock(&container->lock);
> }
>
> -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
> +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
> .name = "iommu-vfio-powerpc",
> .owner = THIS_MODULE,
> .open = tce_iommu_open,
prev parent reply other threads:[~2019-04-03 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 6:47 [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static Wang Hai
2019-03-20 0:39 ` Alexey Kardashevskiy
2019-04-03 18:52 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403125222.021d0908@x1.home \
--to=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanghai26@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox