From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A905BC10F13 for ; Mon, 8 Apr 2019 17:08:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7882620880 for ; Mon, 8 Apr 2019 17:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729082AbfDHRIH (ORCPT ); Mon, 8 Apr 2019 13:08:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33280 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727190AbfDHRIH (ORCPT ); Mon, 8 Apr 2019 13:08:07 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 555C03003737; Mon, 8 Apr 2019 17:08:07 +0000 (UTC) Received: from gondolin (ovpn-117-86.ams2.redhat.com [10.36.117.86]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59637600C0; Mon, 8 Apr 2019 17:07:52 +0000 (UTC) Date: Mon, 8 Apr 2019 19:07:47 +0200 From: Cornelia Huck To: Farhan Ali Cc: Halil Pasic , Eric Farman , Pierre Morel , linux-s390@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Alex Williamson Subject: Re: [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs Message-ID: <20190408190747.12e3618b.cohuck@redhat.com> In-Reply-To: <9e81af36-ebd2-671b-5256-90e8efaad6f2@linux.ibm.com> References: <20190301093902.27799-1-cohuck@redhat.com> <20190301093902.27799-2-cohuck@redhat.com> <9e81af36-ebd2-671b-5256-90e8efaad6f2@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 08 Apr 2019 17:08:07 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 8 Apr 2019 13:02:12 -0400 Farhan Ali wrote: > On 03/01/2019 04:38 AM, Cornelia Huck wrote: > > When we get a solicited interrupt, the start function may have > > been cleared by a csch, but we still have a channel program > > structure allocated. Make it safe to call the cp accessors in > > any case, so we can call them unconditionally. > > > > While at it, also make sure that functions called from other parts > > of the code return gracefully if the channel program structure > > has not been initialized (even though that is a bug in the caller). > > > > Reviewed-by: Eric Farman > > Signed-off-by: Cornelia Huck > > --- > > Hi Connie, > > My series of fixes for vfio-ccw depends on this patch as I would like to > call cp_free unconditionally :) (I had developed my code on top of your > patches). > > Could we pick this patch up as well when/if you pick up my patch series? > I am in the process of sending out a v2. > > Regarding this patch we could merge it as a stand alone patch, separate > from this series. And also the patch LGTM > > Reviewed-by: Farhan Ali Actually, I wanted to ask how people felt about merging this whole series for the next release :) It would be one thing less on my plate...