From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4967BC10F11 for ; Wed, 10 Apr 2019 16:16:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21C7E20830 for ; Wed, 10 Apr 2019 16:16:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387701AbfDJQQT (ORCPT ); Wed, 10 Apr 2019 12:16:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18900 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727027AbfDJQQT (ORCPT ); Wed, 10 Apr 2019 12:16:19 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1A5AB308402B; Wed, 10 Apr 2019 16:16:19 +0000 (UTC) Received: from gondolin (ovpn-204-33.brq.redhat.com [10.40.204.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2C066013A; Wed, 10 Apr 2019 16:16:15 +0000 (UTC) Date: Wed, 10 Apr 2019 18:16:12 +0200 From: Cornelia Huck To: Halil Pasic Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky , Sebastian Ott , virtualization@lists.linux-foundation.org, Christian Borntraeger , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman Subject: Re: [RFC PATCH 05/12] s390/cio: add protected virtualization support to cio Message-ID: <20190410181612.70734815.cohuck@redhat.com> In-Reply-To: <20190410150225.61b86cd9@oc2783563651> References: <20190404231622.52531-1-pasic@linux.ibm.com> <20190404231622.52531-6-pasic@linux.ibm.com> <20190409195548.6dea6e40.cohuck@redhat.com> <20190410021044.4da3e847@oc2783563651> <20190410102557.1ba89d96.cohuck@redhat.com> <20190410150225.61b86cd9@oc2783563651> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 10 Apr 2019 16:16:19 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 10 Apr 2019 15:02:25 +0200 Halil Pasic wrote: > On Wed, 10 Apr 2019 10:25:57 +0200 > Cornelia Huck wrote: > > So, what is a high-level summary of areas that need the treatment? > > What I get from looking at the patches so far, it's: > > - stuff that is written by the hypervisor's interrupt injection code: > > IRB, indicators, etc. > > In interrupt context IRB behaves like a control block. We don't have > to make it shared. > > I moved IRB because of snse: > > > @@ -329,9 +329,9 @@ ccw_device_do_sense(struct ccw_device *cdev, struct > irb *irb) /* > * We have ending status but no sense information. Do a basic > sense. */ > - sense_ccw = &to_io_private(sch)->sense_ccw; > + sense_ccw = &to_io_private(sch)->dma_area->sense_ccw; > sense_ccw->cmd_code = CCW_CMD_BASIC_SENSE; > - sense_ccw->cda = (__u32) __pa(cdev->private->irb.ecw); > + sense_ccw->cda = (__u32) __pa(cdev->private->dma_area->irb.ecw); > > as the irb.ecw is used as channel program data. And that needs to be > shared. Ah, I see. So it's more "guest points to some memory where the hypervisor needs to write data"? > > > - buffers that are filled by a channel program: sense, sense id, etc. > > - ccws themselves (because of translation?) > > > > Right. The idea is: smallish, basically fixed size a readily available > control blocks (specified as a ) are copied back and forth by the As a what? :) > ultravisor (via SIE SD). Ok. It's really hard to be sure from the outside what falls into which category :(