From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Krish Sadhukhan <krish.sadhukhan@oracle.com>,
kvm@vger.kernel.org, rkrcmar@redhat.com, jmattson@google.com
Subject: Re: [PATCH 5/6 v5][KVM nVMX]: nested_vmx_check_vmentry_postreqs() should return VMX_EXIT_REASONS_FAILED_VMENTRY | EXIT_REASON_INVALID_STATE for error conditions
Date: Thu, 11 Apr 2019 09:29:53 -0700 [thread overview]
Message-ID: <20190411162952.GC29427@linux.intel.com> (raw)
In-Reply-To: <651d20e2-dc37-e6b5-46c7-fed947b6f8ed@redhat.com>
On Thu, Apr 11, 2019 at 02:14:35PM +0200, Paolo Bonzini wrote:
> On 11/04/19 02:15, Krish Sadhukhan wrote:
> > May be we should also rename its counterpart
> > (i.e.,nested_vmx_check_vmentry_prereqs) to something like
> > nested_vmx_check_vmentry_pre_guest_state or something similar ?
>
> I think we should have three functions
> nested_vmx_vmentry_check_{controls,host_state,guest_state}.
Four if you count nested_vmx_load_msr(). But anyways, I agree.
On a related subject, an invalid guest activity state results in a VM-Exit,
not VM-Fail, i.e. nested_check_guest_non_reg_state() belongs in
nested_vmx_check_vmentry_postreqs(). Moving that code to its proper
location would eliminate the last odditiy for renaming "postreqs" to
nested_vmx_vmentry_check_guest_state().
I'll send a series, including patches 1 and 2 (the PAT checks) from
Krish's series?
next prev parent reply other threads:[~2019-04-11 16:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 21:35 [KVM nVMX]: Check "load IA32_PAT" VM-exit{entry} controls on vmentry of L2 guests (v5) Krish Sadhukhan
2019-04-08 21:35 ` [PATCH 1/6 v5][KVM nVMX]: Check "load IA32_PAT" VM-exit control on vmentry Krish Sadhukhan
2019-04-10 9:42 ` Paolo Bonzini
2019-04-08 21:35 ` [PATCH 2/6 v5][KVM nVMX]: Check "load IA32_PAT" VM-entry " Krish Sadhukhan
2019-04-08 21:35 ` [PATCH 3/6 v5][KVM nVMX]: Move the checks for Guest Control Registers and Guest MSRs to a separate function Krish Sadhukhan
2019-04-08 21:35 ` [PATCH 4/6 v5][KVM nVMX]: nested_check_guest_cregs_dregs_msrs() should return -EINVAL for error conditions Krish Sadhukhan
2019-04-09 16:20 ` Sean Christopherson
2019-04-08 21:35 ` [PATCH 5/6 v5][KVM nVMX]: nested_vmx_check_vmentry_postreqs() should return VMX_EXIT_REASONS_FAILED_VMENTRY | EXIT_REASON_INVALID_STATE " Krish Sadhukhan
2019-04-09 16:20 ` Sean Christopherson
2019-04-10 9:50 ` Paolo Bonzini
2019-04-10 16:08 ` Sean Christopherson
2019-04-10 17:05 ` Paolo Bonzini
2019-04-10 17:55 ` Sean Christopherson
2019-04-11 0:15 ` Krish Sadhukhan
2019-04-11 12:14 ` Paolo Bonzini
2019-04-11 16:29 ` Sean Christopherson [this message]
2019-04-11 18:15 ` Krish Sadhukhan
2019-04-08 21:35 ` [PATCH 6/6 v5][kvm-unit-test nVMX]: Check "load IA32_PAT" on vmentry of L2 guests Krish Sadhukhan
2019-04-10 12:03 ` Paolo Bonzini
2019-04-10 17:17 ` Sean Christopherson
2019-04-10 17:22 ` Paolo Bonzini
2019-04-10 17:34 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411162952.GC29427@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox