From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC55C10F13 for ; Thu, 11 Apr 2019 15:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A693206BA for ; Thu, 11 Apr 2019 15:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726644AbfDKP7q (ORCPT ); Thu, 11 Apr 2019 11:59:46 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47850 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbfDKP7q (ORCPT ); Thu, 11 Apr 2019 11:59:46 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3BFxEAw031368 for ; Thu, 11 Apr 2019 11:59:45 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rt841aasg-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 11 Apr 2019 11:59:41 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Apr 2019 16:58:37 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 11 Apr 2019 16:58:34 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3BFwXn613303906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Apr 2019 15:58:33 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EEC1CAE055; Thu, 11 Apr 2019 15:58:32 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C9EBAE053; Thu, 11 Apr 2019 15:58:32 +0000 (GMT) Received: from oc2783563651 (unknown [9.152.224.111]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 11 Apr 2019 15:58:32 +0000 (GMT) Date: Thu, 11 Apr 2019 17:58:31 +0200 From: Halil Pasic To: Eric Farman Cc: Cornelia Huck , linux-s390@vger.kernel.org, Pierre Morel , kvm@vger.kernel.org, qemu-s390x@nongnu.org, Farhan Ali , qemu-devel@nongnu.org, Alex Williamson Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs In-Reply-To: <4a692c11-edb2-93f9-7d8e-96a73a7ecdae@linux.ibm.com> References: <20190301093902.27799-1-cohuck@redhat.com> <20190301093902.27799-2-cohuck@redhat.com> <9e81af36-ebd2-671b-5256-90e8efaad6f2@linux.ibm.com> <20190408190747.12e3618b.cohuck@redhat.com> <20190410013434.7cea1971@oc2783563651> <4a692c11-edb2-93f9-7d8e-96a73a7ecdae@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19041115-0016-0000-0000-0000026DD099 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19041115-0017-0000-0000-000032CA076D Message-Id: <20190411175831.7be345f4@oc2783563651> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-04-11_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904110106 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 10 Apr 2019 22:59:41 -0400 Eric Farman wrote: > r the next release :) It would be one thing less on my plate... > >> > > > > Sorry I was not able to spend any significant amount of time on this > > lately. > > > > Gave the combined set (this + Farhans fio-ccw fixes for kernel > > stacktraces v2) it a bit of smoke testing after some minor adjustments > > to make it compile: > > > > --- a/drivers/s390/cio/vfio_ccw_ops.c > > +++ b/drivers/s390/cio/vfio_ccw_ops.c > > @@ -13,6 +13,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "vfio_ccw_private.h" > > > > > > Hrm... Taking today's master, and the two series you mention (slight > adjustment to apply patch 3 of Connie's series, because part of it was > split out a few weeks ago), and I don't encounter this. Tried switching > between SLUB/SLAB, but still compiles fine. Let me guess: you have CONFIG_PCI in our .config, right? In arch/s390/include/asm/pci_io.h we have #ifndef _ASM_S390_PCI_IO_H #define _ASM_S390_PCI_IO_H #ifdef CONFIG_PCI #include #include and pci_io.h comes in via include/linux/vfio.h include/linux/iommu.h include/linux/scatterlist.h arch/s390/include/asm/io.h arch/s390/include/asm/pci_io.h Figured it out with help from Farhan. Took me quite some time. Regards, Halil