From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15860C10F0E for ; Mon, 15 Apr 2019 16:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D503721908 for ; Mon, 15 Apr 2019 16:45:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727646AbfDOQpX (ORCPT ); Mon, 15 Apr 2019 12:45:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56992 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbfDOQpW (ORCPT ); Mon, 15 Apr 2019 12:45:22 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C1621307D84F; Mon, 15 Apr 2019 16:45:22 +0000 (UTC) Received: from gondolin (unknown [10.40.205.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30FD760C05; Mon, 15 Apr 2019 16:45:19 +0000 (UTC) Date: Mon, 15 Apr 2019 18:45:15 +0200 From: Cornelia Huck To: Farhan Ali Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, farman@linux.ibm.com, pasic@linux.ibm.com, pmorel@linux.ibm.com Subject: Re: [RFC v2 0/3] fio-ccw fixes for kernel stacktraces Message-ID: <20190415184515.570ed059.cohuck@redhat.com> In-Reply-To: References: Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 15 Apr 2019 16:45:22 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 8 Apr 2019 17:05:30 -0400 Farhan Ali wrote: > Hi, > > I have recently seen some interesting kernel stacktraces while > testing vfio-ccw mediated devices. These stack traces are seen > when things don't go right, for example when a guest crashes or > dies while still doing some I/O on the mediated device. > > I have also come across an issue in the common vfio code as > well which I reported upstream (https://marc.info/?l=kvm&m=155369393523503&w=2) > and submitted a patch separately for it > (https://marc.info/?l=kvm&m=155414703613868&w=2). > > I would appreciate any review or feedback on these patches. > > Thanks > Farhan > > ChangeLog > --------- > v1 -> v2 > - Use the return code from cio_cancel_halt_clear to prevent > waiting unnecessarily (patch 2). > > - No need to reset the device on the remove path (patch 3). > > Farhan Ali (3): > vfio-ccw: Do not call flush_workqueue while holding the spinlock > vfio-ccw: Prevent quiesce function going into an infinite loop > vfio-ccw: Release any channel program when releasing/removing vfio-ccw > mdev > > drivers/s390/cio/vfio_ccw_drv.c | 27 ++++++++++++--------------- > drivers/s390/cio/vfio_ccw_ops.c | 11 ++++++++++- > 2 files changed, 22 insertions(+), 16 deletions(-) > Thanks, queued patches 1 and 3.