From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E266C10F0E for ; Mon, 15 Apr 2019 22:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57ACC20854 for ; Mon, 15 Apr 2019 22:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728147AbfDOW1X (ORCPT ); Mon, 15 Apr 2019 18:27:23 -0400 Received: from mga06.intel.com ([134.134.136.31]:21181 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbfDOW1X (ORCPT ); Mon, 15 Apr 2019 18:27:23 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 15:27:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,355,1549958400"; d="scan'208";a="140951614" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.181]) by fmsmga008.fm.intel.com with ESMTP; 15 Apr 2019 15:27:21 -0700 Date: Mon, 15 Apr 2019 15:27:21 -0700 From: Sean Christopherson To: nadav.amit@gmail.com Cc: Paolo Bonzini , kvm@vger.kernel.org Subject: Re: [kvm-unit-tests PATCH v2] x86: Remove INIT deassertg Message-ID: <20190415222721.GN24010@linux.intel.com> References: <20190415221421.20903-1-nadav.amit@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190415221421.20903-1-nadav.amit@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Apr 15, 2019 at 03:14:21PM -0700, nadav.amit@gmail.com wrote: > From: Nadav Amit > > Currently, the INIT deassert is marked as an edge event instead of a > level, which is wrong. The deassert is actually not needed, as the > arbitration ID should have already been set after boot, and is not > affected by further INIT IPIs. > > Remove the INIT deassert for these reasons. > > Cc: Sean Christopherson > Signed-off-by: Nadav Amit > --- Reviewed-by: Sean Christopherson