* [kvm-unit-tests PATCH v2] x86: Remove INIT deassert
@ 2019-04-15 22:14 nadav.amit
2019-04-15 22:27 ` [kvm-unit-tests PATCH v2] x86: Remove INIT deassertg Sean Christopherson
0 siblings, 1 reply; 3+ messages in thread
From: nadav.amit @ 2019-04-15 22:14 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm, Nadav Amit, Sean Christopherson
From: Nadav Amit <nadav.amit@gmail.com>
Currently, the INIT deassert is marked as an edge event instead of a
level, which is wrong. The deassert is actually not needed, as the
arbitration ID should have already been set after boot, and is not
affected by further INIT IPIs.
Remove the INIT deassert for these reasons.
Cc: Sean Christopherson <sean.j.christopherson@intel.com>
Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
---
x86/cstart.S | 1 -
x86/cstart64.S | 1 -
2 files changed, 2 deletions(-)
diff --git a/x86/cstart.S b/x86/cstart.S
index 143317e..79c5024 100644
--- a/x86/cstart.S
+++ b/x86/cstart.S
@@ -186,7 +186,6 @@ smp_init:
rep/movsb
mov $APIC_DEFAULT_PHYS_BASE, %eax
movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT | APIC_INT_ASSERT), APIC_ICR(%eax)
- movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT), APIC_ICR(%eax)
movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_STARTUP), APIC_ICR(%eax)
call fwcfg_get_nb_cpus
1: pause
diff --git a/x86/cstart64.S b/x86/cstart64.S
index 21db10f..e38767b 100644
--- a/x86/cstart64.S
+++ b/x86/cstart64.S
@@ -285,7 +285,6 @@ smp_init:
rep/movsb
mov $APIC_DEFAULT_PHYS_BASE, %eax
movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT | APIC_INT_ASSERT), APIC_ICR(%rax)
- movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_INIT), APIC_ICR(%rax)
movl $(APIC_DEST_ALLBUT | APIC_DEST_PHYSICAL | APIC_DM_STARTUP), APIC_ICR(%rax)
call fwcfg_get_nb_cpus
1: pause
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [kvm-unit-tests PATCH v2] x86: Remove INIT deassertg
2019-04-15 22:14 [kvm-unit-tests PATCH v2] x86: Remove INIT deassert nadav.amit
@ 2019-04-15 22:27 ` Sean Christopherson
2019-04-16 8:28 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Sean Christopherson @ 2019-04-15 22:27 UTC (permalink / raw)
To: nadav.amit; +Cc: Paolo Bonzini, kvm
On Mon, Apr 15, 2019 at 03:14:21PM -0700, nadav.amit@gmail.com wrote:
> From: Nadav Amit <nadav.amit@gmail.com>
>
> Currently, the INIT deassert is marked as an edge event instead of a
> level, which is wrong. The deassert is actually not needed, as the
> arbitration ID should have already been set after boot, and is not
> affected by further INIT IPIs.
>
> Remove the INIT deassert for these reasons.
>
> Cc: Sean Christopherson <sean.j.christopherson@intel.com>
> Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
> ---
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [kvm-unit-tests PATCH v2] x86: Remove INIT deassertg
2019-04-15 22:27 ` [kvm-unit-tests PATCH v2] x86: Remove INIT deassertg Sean Christopherson
@ 2019-04-16 8:28 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2019-04-16 8:28 UTC (permalink / raw)
To: Sean Christopherson, nadav.amit; +Cc: kvm
On 16/04/19 00:27, Sean Christopherson wrote:
>> Currently, the INIT deassert is marked as an edge event instead of a
>> level, which is wrong. The deassert is actually not needed, as the
>> arbitration ID should have already been set after boot, and is not
>> affected by further INIT IPIs.
>>
>> Remove the INIT deassert for these reasons.
>
> Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-16 8:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-15 22:14 [kvm-unit-tests PATCH v2] x86: Remove INIT deassert nadav.amit
2019-04-15 22:27 ` [kvm-unit-tests PATCH v2] x86: Remove INIT deassertg Sean Christopherson
2019-04-16 8:28 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox