From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=PCIz=SS=vger.kernel.org=kvm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C0E24C10F13
	for <kvm@archiver.kernel.org>; Tue, 16 Apr 2019 17:27:14 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 94BBA2064A
	for <kvm@archiver.kernel.org>; Tue, 16 Apr 2019 17:27:14 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729909AbfDPR1N (ORCPT <rfc822;kvm@archiver.kernel.org>);
        Tue, 16 Apr 2019 13:27:13 -0400
Received: from mga09.intel.com ([134.134.136.24]:39139 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727180AbfDPR1N (ORCPT <rfc822;kvm@vger.kernel.org>);
        Tue, 16 Apr 2019 13:27:13 -0400
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
  by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 10:27:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,358,1549958400"; 
   d="scan'208";a="165276382"
Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.181])
  by fmsmga001.fm.intel.com with ESMTP; 16 Apr 2019 10:27:12 -0700
Date:   Tue, 16 Apr 2019 10:27:11 -0700
From:   Sean Christopherson <sean.j.christopherson@intel.com>
To:     Liran Alon <liran.alon@oracle.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        kvm@vger.kernel.org, Wanpeng Li <wanpengli@tencent.com>
Subject: Re: [PATCH 6/7] KVM: lapic: Clean up the code for handling of a
 pre-expired hv_timer
Message-ID: <20190416172711.GB21674@linux.intel.com>
References: <20190412201834.10831-1-sean.j.christopherson@intel.com>
 <20190412201834.10831-7-sean.j.christopherson@intel.com>
 <9DCCF040-F617-4E10-9AA3-715F6EB51ADA@oracle.com>
 <20190415163251.GE24010@linux.intel.com>
 <B074B4E8-77D1-4222-A49C-4DA02C263A4C@oracle.com>
 <20190416163925.GA21674@linux.intel.com>
 <EBF51FC6-416E-4D44-87AB-5DFE8D9430B3@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <EBF51FC6-416E-4D44-87AB-5DFE8D9430B3@oracle.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: kvm-owner@vger.kernel.org
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org

On Tue, Apr 16, 2019 at 07:48:42PM +0300, Liran Alon wrote:
 Yes I understood that already.
> I don’t think it contradicts the fact that the checks I mentioned above
> should be moved out of start_hv_timer().

Ah, I misread your comment.  I think.  My head is spinning trying to
work through this code.

> > I think Paolo's suggestion of moving the logic up into restart_apic_timer()
> > is the way to go as it reduces the multiplexing down on start_hv_timer()'s
> > return value.
> > 
> 
> Yes I agree. I plan to do so.

And because I misread your comment, I already created this patch.  I'll
send it out shortly.