From: Leo Yan <leo.yan@linaro.org>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Will Deacon <Will.Deacon@arm.com>,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Eric Auger <eric.auger@redhat.com>,
Robin Murphy <Robin.Murphy@arm.com>
Subject: Re: [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling
Date: Wed, 24 Apr 2019 22:21:27 +0800 [thread overview]
Message-ID: <20190424142127.GC8948@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20190408012719.16158-1-leo.yan@linaro.org>
Hi Will,
On Mon, Apr 08, 2019 at 09:27:16AM +0800, Leo Yan wrote:
> When enable vfio-pci mode for NIC driver on Juno board, the IRQ is
> failed to forward properly from host to guest, finally root caused this
> issue is related with kvmtool cannot re-enable INTx mode properly.
>
> So the basic working flow to reproduce this issue is as below:
>
> Host Guest
> ------------- --------------------
> INTx mode
> MSI enable failed in NIC driver
> MSI disable in NIC driver
> Switch back to INTx mode --> kvmtool doesn't support
>
> So this patch is to support INTx mode re-enabling; patch 0001 is one
> minor fixing up for eventfd releasing; patch 0002 introduces a new
> function vfio_pci_init_intx() which is used to finish INTx one-time
> initialisation; patch 0003 is the core patch for support INTx mode
> re-enabling, when kvmtool detects MSI is disabled it rollbacks to INTx
> mode.
>
> This patch set has been tested on Juno-r2 board.
>
> == Changes for V4 ==
> * Removed the unnecessary comments in patch 0003 (Jean-Philippe).
> * Added Jean-Philippe's review tags.
Could you pick up these 3 patches and merge into kvmtool? All of them
has been received reviewing tag from Jean-Philippe. Thanks.
> == Changes for V3 ==
> * Add new function vfio_pci_init_intx() for one-time initialisation.
> * Simplized INTx re-enabling (don't change irq_line anymore at the
> runtime).
>
>
> Leo Yan (3):
> vfio-pci: Release INTx's unmask eventfd properly
> vfio-pci: Add new function for INTx one-time initialisation
> vfio-pci: Re-enable INTx mode when disable MSI/MSIX
>
> include/kvm/vfio.h | 1 +
> vfio/pci.c | 95 ++++++++++++++++++++++++++++++----------------
> 2 files changed, 64 insertions(+), 32 deletions(-)
>
> --
> 2.19.1
>
next prev parent reply other threads:[~2019-04-24 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 1:27 [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling Leo Yan
2019-04-08 1:27 ` [PATCH v4 1/3] vfio-pci: Release INTx's unmask eventfd properly Leo Yan
2019-04-08 1:27 ` [PATCH v4 2/3] vfio-pci: Add new function for INTx one-time initialisation Leo Yan
2019-04-08 1:27 ` [PATCH v4 3/3] vfio-pci: Re-enable INTx mode when disable MSI/MSIX Leo Yan
2019-04-24 14:21 ` Leo Yan [this message]
2019-04-25 14:03 ` [PATCH v4 0/3] vfio-pci: Support INTx mode re-enabling Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424142127.GC8948@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=Marc.Zyngier@arm.com \
--cc=Robin.Murphy@arm.com \
--cc=Will.Deacon@arm.com \
--cc=eric.auger@redhat.com \
--cc=jean-philippe.brucker@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox