public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Documentation: kvm: fix dirty log ioctl arch lists
@ 2019-04-29  8:27 Andrew Jones
  2019-04-29  8:49 ` Cornelia Huck
  2019-04-29 12:06 ` Paolo Bonzini
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Jones @ 2019-04-29  8:27 UTC (permalink / raw)
  To: kvm; +Cc: pbonzini, rkrcmar

KVM_GET_DIRTY_LOG is implemented by all architectures, not just x86,
and KVM_CAP_MANUAL_DIRTY_LOG_PROTECT is additionally implemented by
arm, arm64, and mips.

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
I skimmed all ioctls in the document to see if others needed to be
fixed, but from my quick skim the only dirty ones seem to be the
dirty log ones.

 Documentation/virtual/kvm/api.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index 67068c47c591..7f3ebc9e7cee 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -321,7 +321,7 @@ cpu's hardware control block.
 4.8 KVM_GET_DIRTY_LOG (vm ioctl)
 
 Capability: basic
-Architectures: x86
+Architectures: all
 Type: vm ioctl
 Parameters: struct kvm_dirty_log (in/out)
 Returns: 0 on success, -1 on error
@@ -3810,7 +3810,7 @@ to I/O ports.
 4.117 KVM_CLEAR_DIRTY_LOG (vm ioctl)
 
 Capability: KVM_CAP_MANUAL_DIRTY_LOG_PROTECT
-Architectures: x86
+Architectures: x86, arm, arm64, mips
 Type: vm ioctl
 Parameters: struct kvm_dirty_log (in)
 Returns: 0 on success, -1 on error
@@ -4799,7 +4799,7 @@ and injected exceptions.
 
 7.18 KVM_CAP_MANUAL_DIRTY_LOG_PROTECT
 
-Architectures: all
+Architectures: x86, arm, arm64, mips
 Parameters: args[0] whether feature should be enabled or not
 
 With this capability enabled, KVM_GET_DIRTY_LOG will not automatically
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: kvm: fix dirty log ioctl arch lists
  2019-04-29  8:27 [PATCH] Documentation: kvm: fix dirty log ioctl arch lists Andrew Jones
@ 2019-04-29  8:49 ` Cornelia Huck
  2019-04-29 12:06 ` Paolo Bonzini
  1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2019-04-29  8:49 UTC (permalink / raw)
  To: Andrew Jones; +Cc: kvm, pbonzini, rkrcmar

On Mon, 29 Apr 2019 10:27:10 +0200
Andrew Jones <drjones@redhat.com> wrote:

> KVM_GET_DIRTY_LOG is implemented by all architectures, not just x86,
> and KVM_CAP_MANUAL_DIRTY_LOG_PROTECT is additionally implemented by
> arm, arm64, and mips.
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> I skimmed all ioctls in the document to see if others needed to be
> fixed, but from my quick skim the only dirty ones seem to be the
> dirty log ones.
> 
>  Documentation/virtual/kvm/api.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation: kvm: fix dirty log ioctl arch lists
  2019-04-29  8:27 [PATCH] Documentation: kvm: fix dirty log ioctl arch lists Andrew Jones
  2019-04-29  8:49 ` Cornelia Huck
@ 2019-04-29 12:06 ` Paolo Bonzini
  1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2019-04-29 12:06 UTC (permalink / raw)
  To: Andrew Jones, kvm; +Cc: rkrcmar

On 29/04/19 10:27, Andrew Jones wrote:
> KVM_GET_DIRTY_LOG is implemented by all architectures, not just x86,
> and KVM_CAP_MANUAL_DIRTY_LOG_PROTECT is additionally implemented by
> arm, arm64, and mips.
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> I skimmed all ioctls in the document to see if others needed to be
> fixed, but from my quick skim the only dirty ones seem to be the
> dirty log ones.

Queued, thanks!

Paolo

>  Documentation/virtual/kvm/api.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 67068c47c591..7f3ebc9e7cee 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -321,7 +321,7 @@ cpu's hardware control block.
>  4.8 KVM_GET_DIRTY_LOG (vm ioctl)
>  
>  Capability: basic
> -Architectures: x86
> +Architectures: all
>  Type: vm ioctl
>  Parameters: struct kvm_dirty_log (in/out)
>  Returns: 0 on success, -1 on error
> @@ -3810,7 +3810,7 @@ to I/O ports.
>  4.117 KVM_CLEAR_DIRTY_LOG (vm ioctl)
>  
>  Capability: KVM_CAP_MANUAL_DIRTY_LOG_PROTECT
> -Architectures: x86
> +Architectures: x86, arm, arm64, mips
>  Type: vm ioctl
>  Parameters: struct kvm_dirty_log (in)
>  Returns: 0 on success, -1 on error
> @@ -4799,7 +4799,7 @@ and injected exceptions.
>  
>  7.18 KVM_CAP_MANUAL_DIRTY_LOG_PROTECT
>  
> -Architectures: all
> +Architectures: x86, arm, arm64, mips
>  Parameters: args[0] whether feature should be enabled or not
>  
>  With this capability enabled, KVM_GET_DIRTY_LOG will not automatically
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-29 12:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-29  8:27 [PATCH] Documentation: kvm: fix dirty log ioctl arch lists Andrew Jones
2019-04-29  8:49 ` Cornelia Huck
2019-04-29 12:06 ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox