From: Dan Carpenter <dan.carpenter@oracle.com>
To: clg@kaod.org
Cc: kvm@vger.kernel.org
Subject: [bug report] KVM: Introduce a 'release' method for KVM devices
Date: Thu, 2 May 2019 10:03:53 +0300 [thread overview]
Message-ID: <20190502070353.GA10616@mwanda> (raw)
Hello Cédric Le Goater,
This is a semi-automatic email about new static checker warnings.
The patch 2bde9b3ec8bd: "KVM: Introduce a 'release' method for KVM
devices" from Apr 18, 2019, leads to the following Smatch complaint:
arch/x86/kvm/../../../virt/kvm/kvm_main.c:2943 kvm_device_release()
warn: variable dereferenced before check 'dev' (see line 2941)
arch/x86/kvm/../../../virt/kvm/kvm_main.c
2938 static int kvm_device_release(struct inode *inode, struct file *filp)
2939 {
2940 struct kvm_device *dev = filp->private_data;
2941 struct kvm *kvm = dev->kvm;
^^^^^^^^
Dereference.
2942
2943 if (!dev)
^^^^
Checked too late.
2944 return -ENODEV;
2945
2946 if (dev->kvm != kvm)
^^^^^^^^^^^^^^^
What is this testing? We just set "kvm = dev->kvm;" at the start.
2947 return -EPERM;
2948
2949 if (dev->ops->release) {
2950 mutex_lock(&kvm->lock);
2951 list_del(&dev->vm_node);
2952 dev->ops->release(dev);
2953 mutex_unlock(&kvm->lock);
2954 }
2955
2956 kvm_put_kvm(kvm);
2957 return 0;
2958 }
regards,
dan carpenter
next reply other threads:[~2019-05-02 7:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 7:03 Dan Carpenter [this message]
2019-05-02 7:09 ` [bug report] KVM: Introduce a 'release' method for KVM devices Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502070353.GA10616@mwanda \
--to=dan.carpenter@oracle.com \
--cc=clg@kaod.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox