public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: nadav.amit@gmail.com
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Andrew Jones <drjones@redhat.com>,
	Nadav Amit <nadav.amit@gmail.com>
Subject: [kvm-unit-tests PATCH v2 0/4] Zero allocated pages
Date: Fri,  3 May 2019 03:32:03 -0700	[thread overview]
Message-ID: <20190503103207.9021-1-nadav.amit@gmail.com> (raw)

From: Nadav Amit <nadav.amit@gmail.com>

For reproducibility, it is best to zero pages before they are used.
There are hidden assumptions on memory being zeroed (by BIOS/KVM), which
might be broken at any given moment. The full argument appears in the
first patch commit log.

Following the first patch that zeros the memory, the rest of the
patch-set removes redundant zeroing do to the additional zeroing.

This patch-set is only tested on x86.

v1->v2:
* Change alloc_pages() as well
* Remove redundant page zeroing [Andrew]

Nadav Amit (4):
  lib/alloc_page: Zero allocated pages
  x86: Remove redeundant page zeroing
  lib: Remove redeundant page zeroing
  arm: Remove redeundant page zeroing

 lib/alloc_page.c         |  4 ++++
 lib/arm/asm/pgtable.h    |  2 --
 lib/arm/mmu.c            |  1 -
 lib/arm64/asm/pgtable.h  |  1 -
 lib/virtio-mmio.c        |  1 -
 lib/x86/intel-iommu.c    |  5 -----
 x86/eventinj.c           |  1 -
 x86/hyperv_connections.c |  4 ----
 x86/vmx.c                | 10 ----------
 x86/vmx_tests.c          | 11 -----------
 10 files changed, 4 insertions(+), 36 deletions(-)

-- 
2.17.1


             reply	other threads:[~2019-05-03 17:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 10:32 nadav.amit [this message]
2019-05-03 10:32 ` [kvm-unit-tests PATCH v2 1/4] lib/alloc_page: Zero allocated pages nadav.amit
2019-05-03 19:10   ` Krish Sadhukhan
2019-05-03 10:32 ` [kvm-unit-tests PATCH v2 2/4] x86: Remove redeundant page zeroing nadav.amit
2019-05-03 19:11   ` Krish Sadhukhan
2019-05-03 10:32 ` [kvm-unit-tests PATCH v2 3/4] lib: " nadav.amit
2019-05-03 19:57   ` Krish Sadhukhan
2019-05-03 10:32 ` [kvm-unit-tests PATCH v2 4/4] arm: " nadav.amit
2019-05-09  8:59   ` Alexandru Elisei
2019-05-20 14:19 ` [kvm-unit-tests PATCH v2 0/4] Zero allocated pages Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503103207.9021-1-nadav.amit@gmail.com \
    --to=nadav.amit@gmail.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox