Re: [kvm-unit-tests PATCH v2 3/4] lib: Remove redeundant page zeroing

Krish Sadhukhan
2019-05-03T19:58:01Z

On 05/03/2019 03:32 AM, nadav.amit@gmail.com wrote:
> From: Nadav Amit <nadav.amit@gmail.com>
>
> Now that alloc_page() zeros the page, remove the redundant page zeroing.
>
> Suggested-by: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
> ---
> lib/virtio-mmio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/virtio-mmio.c b/lib/virtio-mmio.c
> index 57fe78e..e5e8f66 100644
> --- a/lib/virtio-mmio.c
> +++ b/lib/virtio-mmio.c
> @@ -56,7 +56,6 @@ static struct virtqueue *vm_setup_vq(struct virtio_device *vdev,
> vq = calloc(1, sizeof(*vq));
> assert(VIRTIO_MMIO_QUEUE_SIZE_MIN <= 2*PAGE_SIZE);
> queue = alloc_pages(1);
> - memset(queue, 0, 2*PAGE_SIZE);
> assert(vq && queue);
>
> writel(index, vm_dev->base + VIRTIO_MMIO_QUEUE_SEL);

Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>