Re: [PATCH 01/15] KVM: nVMX: Don't dump VMCS if virtual APIC page can't be mapped

Paolo Bonzini
2019-05-07T20:09:35Z

On 07/05/19 11:06, Sean Christopherson wrote:
> ... as a malicious userspace can run a toy guest to generate invalid
> virtual-APIC page addresses in L1, i.e. flood the kernel log with error
> messages.
>
> Fixes: 690908104e39d ("KVM: nVMX: allow tests to use bad virtual-APIC page address")
> Cc: stable@vger.kernel.org
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>

The same is true even of dump_vmcs caused by emulation failures. I'm
thinking of just hiding dump_vmcs beneath a module parameter.

Paolo