From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04B4C04A6B for ; Wed, 8 May 2019 13:54:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C261320644 for ; Wed, 8 May 2019 13:54:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="pfRLPHPl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726732AbfEHNy6 (ORCPT ); Wed, 8 May 2019 09:54:58 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35984 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbfEHNy6 (ORCPT ); Wed, 8 May 2019 09:54:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fZD1MoMGqALYimoOBuM5A+SPAn0BauM3Ob0ObHySi70=; b=pfRLPHPlacy/hp+n76u0JY6mI 4m/hLoi6Ly6wgCX9gzT/2uhT5icYsNiZlBWeITMyrvRQKQntRWXQeRKSkpe+ubcd3uyG0VpPhUHaP erhVHjXyRW63sPrezzVBV02W1sfIJMHmHc+vRqO/rodmHdurhZ0jUHdixYksIlEM5AcUd6RgIq4VK mKNRe3/rCaX87BOFT831OPunNTQXZaHoVpYjeFby0CXQSfqYQK8tURT96pv3goljdkqbUoobfpzfI scvnAZa72YPcwtFJcMA8y/I77+bzHQYYShKF6odr+B4W9bNP8lppWiZ00cDZ/tNxPH1WoLjP1VL+6 e37RamlHA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hON29-0000xX-Uj; Wed, 08 May 2019 13:54:57 +0000 Date: Wed, 8 May 2019 06:54:57 -0700 From: Christoph Hellwig To: Sebastian Ott Cc: Halil Pasic , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Cornelia Huck , Martin Schwidefsky , virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Christoph Hellwig , Thomas Huth , Christian Borntraeger , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman Subject: Re: [PATCH 06/10] s390/cio: add basic protected virtualization support Message-ID: <20190508135457.GA3530@infradead.org> References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-7-pasic@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, May 08, 2019 at 03:46:42PM +0200, Sebastian Ott wrote: > > + io_priv->dma_area = dma_alloc_coherent(&sch->dev, > > + sizeof(*io_priv->dma_area), > > + &io_priv->dma_area_dma, GFP_KERNEL); > > This needs GFP_DMA. > You use a genpool for ccw_private->dma and not for iopriv->dma - looks > kinda inconsistent. dma_alloc_* never needs GFP_DMA. It selects the zone to allocate from based on the dma_coherent_mask of the device.