From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Krish Sadhukhan <krish.sadhukhan@oracle.com>,
Andrew Jones <drjones@redhat.com>,
Alexandru Elisei <alexandru.elisei@arm.com>
Subject: Re: [kvm-unit-tests PATCH v3 0/4] Zero allocated pages
Date: Fri, 10 May 2019 08:55:46 -0400 [thread overview]
Message-ID: <20190510125546.GD12248@char.us.oracle.com> (raw)
In-Reply-To: <20190509200558.12347-1-nadav.amit@gmail.com>
On Thu, May 09, 2019 at 01:05:54PM -0700, Nadav Amit wrote:
> For reproducibility, it is best to zero pages before they are used.
> There are hidden assumptions on memory being zeroed (by BIOS/KVM), which
> might be broken at any given moment. The full argument appears in the
> first patch commit log.
>
> Following the first patch that zeros the memory, the rest of the
> patch-set removes redundant zeroing do to the additional zeroing.
>
> This patch-set is only tested on x86.
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
for all of them please.
>
> v2->v3:
> * Typos [Alexandru]
>
> v1->v2:
> * Change alloc_pages() as well
> * Remove redundant page zeroing [Andrew]
>
> Nadav Amit (4):
> lib/alloc_page: Zero allocated pages
> x86: Remove redundant page zeroing
> lib: Remove redundant page zeroing
> arm: Remove redundant page zeroing
>
> lib/alloc_page.c | 4 ++++
> lib/arm/asm/pgtable.h | 2 --
> lib/arm/mmu.c | 1 -
> lib/arm64/asm/pgtable.h | 1 -
> lib/virtio-mmio.c | 1 -
> lib/x86/intel-iommu.c | 5 -----
> x86/eventinj.c | 1 -
> x86/hyperv_connections.c | 4 ----
> x86/vmx.c | 10 ----------
> x86/vmx_tests.c | 11 -----------
> 10 files changed, 4 insertions(+), 36 deletions(-)
>
> --
> 2.17.1
>
prev parent reply other threads:[~2019-05-10 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 20:05 [kvm-unit-tests PATCH v3 0/4] Zero allocated pages Nadav Amit
2019-05-09 20:05 ` [kvm-unit-tests PATCH v3 1/4] lib/alloc_page: " Nadav Amit
2019-05-15 9:18 ` Andrew Jones
2019-05-09 20:05 ` [kvm-unit-tests PATCH v3 2/4] x86: Remove redundant page zeroing Nadav Amit
2019-05-09 20:05 ` [kvm-unit-tests PATCH v3 3/4] lib: " Nadav Amit
2019-05-15 9:19 ` Andrew Jones
2019-05-09 20:05 ` [kvm-unit-tests PATCH v3 4/4] arm: " Nadav Amit
2019-05-15 9:27 ` Andrew Jones
2019-05-10 12:55 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510125546.GD12248@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=alexandru.elisei@arm.com \
--cc=drjones@redhat.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox