From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFC23C04A6B for ; Fri, 10 May 2019 14:08:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A35312175B for ; Fri, 10 May 2019 14:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727823AbfEJOIG (ORCPT ); Fri, 10 May 2019 10:08:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33561 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727521AbfEJOIF (ORCPT ); Fri, 10 May 2019 10:08:05 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DAF773082B4C; Fri, 10 May 2019 14:08:00 +0000 (UTC) Received: from gondolin (dhcp-192-213.str.redhat.com [10.33.192.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25E1166848; Fri, 10 May 2019 14:07:47 +0000 (UTC) Date: Fri, 10 May 2019 16:07:44 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: Christian Borntraeger , Halil Pasic , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky , Sebastian Ott , virtualization@lists.linux-foundation.org, Christoph Hellwig , Thomas Huth , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman Subject: Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue Message-ID: <20190510160744.00285367.cohuck@redhat.com> In-Reply-To: References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-2-pasic@linux.ibm.com> <20190503111724.70c6ec37.cohuck@redhat.com> <20190503160421-mutt-send-email-mst@kernel.org> <20190504160340.29f17b98.pasic@linux.ibm.com> <20190505131523.159bec7c.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 10 May 2019 14:08:05 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 7 May 2019 15:58:12 +0200 Christian Borntraeger wrote: > On 05.05.19 13:15, Cornelia Huck wrote: > > On Sat, 4 May 2019 16:03:40 +0200 > > Halil Pasic wrote: > > > >> On Fri, 3 May 2019 16:04:48 -0400 > >> "Michael S. Tsirkin" wrote: > >> > >>> On Fri, May 03, 2019 at 11:17:24AM +0200, Cornelia Huck wrote: > >>>> On Fri, 26 Apr 2019 20:32:36 +0200 > >>>> Halil Pasic wrote: > >>>> > >>>>> The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") > >>>>> establishes a new way of allocating virtqueues (as a part of the effort > >>>>> that taught DMA to virtio rings). > >>>>> > >>>>> In the future we will want virtio-ccw to use the DMA API as well. > >>>>> > >>>>> Let us switch from the legacy method of allocating virtqueues to > >>>>> vring_create_virtqueue() as the first step into that direction. > >>>>> > >>>>> Signed-off-by: Halil Pasic > >>>>> --- > >>>>> drivers/s390/virtio/virtio_ccw.c | 30 +++++++++++------------------- > >>>>> 1 file changed, 11 insertions(+), 19 deletions(-) > >>>> > >>>> Reviewed-by: Cornelia Huck > >>>> > >>>> I'd vote for merging this patch right away for 5.2. > >>> > >>> So which tree is this going through? mine? > >>> > >> > >> Christian, what do you think? If the whole series is supposed to go in > >> in one go (which I hope it is), via Martin's tree could be the simplest > >> route IMHO. > > > > > > The first three patches are virtio(-ccw) only and the those are the ones > > that I think are ready to go. > > > > I'm not feeling comfortable going forward with the remainder as it > > stands now; waiting for some other folks to give feedback. (They are > > touching/interacting with code parts I'm not so familiar with, and lack > > of documentation, while not the developers' fault, does not make it > > easier.) > > > > Michael, would you like to pick up 1-3 for your tree directly? That > > looks like the easiest way. > > Agreed. Michael please pick 1-3. > We will continue to review 4- first and then see which tree is best. Michael, please let me know if you'll pick directly or whether I should post a series. [Given that the patches are from one virtio-ccw maintainer and reviewed by the other, picking directly would eliminate an unnecessary indirection :)]