From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B7EC04AA7 for ; Mon, 13 May 2019 12:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E801620879 for ; Mon, 13 May 2019 12:29:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728993AbfEMM3y (ORCPT ); Mon, 13 May 2019 08:29:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbfEMM3x (ORCPT ); Mon, 13 May 2019 08:29:53 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 114487E427; Mon, 13 May 2019 12:29:53 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8E5319C67; Mon, 13 May 2019 12:29:47 +0000 (UTC) Date: Mon, 13 May 2019 14:29:45 +0200 From: Cornelia Huck To: Michael Mueller Cc: "Michael S. Tsirkin" , Christian Borntraeger , Halil Pasic , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky , Sebastian Ott , virtualization@lists.linux-foundation.org, Christoph Hellwig , Thomas Huth , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman Subject: Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue Message-ID: <20190513142945.27e5921f.cohuck@redhat.com> In-Reply-To: References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-2-pasic@linux.ibm.com> <20190503111724.70c6ec37.cohuck@redhat.com> <20190503160421-mutt-send-email-mst@kernel.org> <20190504160340.29f17b98.pasic@linux.ibm.com> <20190505131523.159bec7c.cohuck@redhat.com> <20190510160744.00285367.cohuck@redhat.com> <20190512124730-mutt-send-email-mst@kernel.org> <20190513115227.1d316ec8.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 13 May 2019 12:29:53 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 13 May 2019 14:27:35 +0200 Michael Mueller wrote: > On 13.05.19 11:52, Cornelia Huck wrote: > > On Sun, 12 May 2019 12:47:39 -0400 > > "Michael S. Tsirkin" wrote: > > > >> On Fri, May 10, 2019 at 04:07:44PM +0200, Cornelia Huck wrote: > >>> On Tue, 7 May 2019 15:58:12 +0200 > >>> Christian Borntraeger wrote: > >>> > >>>> On 05.05.19 13:15, Cornelia Huck wrote: > >>>>> On Sat, 4 May 2019 16:03:40 +0200 > >>>>> Halil Pasic wrote: > >>>>> > >>>>>> On Fri, 3 May 2019 16:04:48 -0400 > >>>>>> "Michael S. Tsirkin" wrote: > >>>>>> > >>>>>>> On Fri, May 03, 2019 at 11:17:24AM +0200, Cornelia Huck wrote: > >>>>>>>> On Fri, 26 Apr 2019 20:32:36 +0200 > >>>>>>>> Halil Pasic wrote: > >>>>>>>> > >>>>>>>>> The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") > >>>>>>>>> establishes a new way of allocating virtqueues (as a part of the effort > >>>>>>>>> that taught DMA to virtio rings). > >>>>>>>>> > >>>>>>>>> In the future we will want virtio-ccw to use the DMA API as well. > >>>>>>>>> > >>>>>>>>> Let us switch from the legacy method of allocating virtqueues to > >>>>>>>>> vring_create_virtqueue() as the first step into that direction. > >>>>>>>>> > >>>>>>>>> Signed-off-by: Halil Pasic > >>>>>>>>> --- > >>>>>>>>> drivers/s390/virtio/virtio_ccw.c | 30 +++++++++++------------------- > >>>>>>>>> 1 file changed, 11 insertions(+), 19 deletions(-) > >>>>>>>> > >>>>>>>> Reviewed-by: Cornelia Huck > >>>>>>>> > >>>>>>>> I'd vote for merging this patch right away for 5.2. > >>>>>>> > >>>>>>> So which tree is this going through? mine? > >>>>>>> > >>>>>> > >>>>>> Christian, what do you think? If the whole series is supposed to go in > >>>>>> in one go (which I hope it is), via Martin's tree could be the simplest > >>>>>> route IMHO. > >>>>> > >>>>> > >>>>> The first three patches are virtio(-ccw) only and the those are the ones > >>>>> that I think are ready to go. > >>>>> > >>>>> I'm not feeling comfortable going forward with the remainder as it > >>>>> stands now; waiting for some other folks to give feedback. (They are > >>>>> touching/interacting with code parts I'm not so familiar with, and lack > >>>>> of documentation, while not the developers' fault, does not make it > >>>>> easier.) > >>>>> > >>>>> Michael, would you like to pick up 1-3 for your tree directly? That > >>>>> looks like the easiest way. > >>>> > >>>> Agreed. Michael please pick 1-3. > >>>> We will continue to review 4- first and then see which tree is best. > >>> > >>> Michael, please let me know if you'll pick directly or whether I should > >>> post a series. > >>> > >>> [Given that the patches are from one virtio-ccw maintainer and reviewed > >>> by the other, picking directly would eliminate an unnecessary > >>> indirection :)] > >> > >> picked them > > > > Thanks! > > > > Connie, > > if I get you right here, you don't need a v2 for the > patches 1 through 3? Exactly, they are all queued in Michael's tree. > > Thanks, > Michael >