Re: [PATCH v2 2/7] s390/cio: Set vfio-ccw FSM state before ioeventfd

Farhan Ali
2019-05-15T14:36:32Z

On 05/14/2019 07:42 PM, Eric Farman wrote:
> Otherwise, the guest can believe it's okay to start another I/O
> and bump into the non-idle state. This results in a cc=2 (with
> the asynchronous CSCH/HSCH code) returned to the guest, which is
> unfortunate since everything is otherwise working normally.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_drv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 0b3b9de45c60..ddd21b6149fd 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -86,11 +86,11 @@ static void vfio_ccw_sch_io_todo(struct work_struct *work)
> }
> memcpy(private->io_region->irb_area, irb, sizeof(*irb));
>
> - if (private->io_trigger)
> - eventfd_signal(private->io_trigger, 1);
> -
> if (private->mdev && is_final)
> private->state = VFIO_CCW_STATE_IDLE;
> +
> + if (private->io_trigger)
> + eventfd_signal(private->io_trigger, 1);
> }
>
> /*
>
Reviewed-by: Farhan Ali <alifm@linux.ibm.com>