From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D9AC04E53 for ; Wed, 15 May 2019 17:24:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8270F20815 for ; Wed, 15 May 2019 17:24:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbfEORYa convert rfc822-to-8bit (ORCPT ); Wed, 15 May 2019 13:24:30 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41476 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726678AbfEORYa (ORCPT ); Wed, 15 May 2019 13:24:30 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4FHN2ZQ095349 for ; Wed, 15 May 2019 13:24:28 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sgnshm9ma-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 15 May 2019 13:24:27 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 May 2019 18:24:26 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 15 May 2019 18:24:22 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x4FHOLOm58065140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 May 2019 17:24:21 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E10E2AE056; Wed, 15 May 2019 17:24:20 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 156E4AE059; Wed, 15 May 2019 17:24:20 +0000 (GMT) Received: from oc2783563651 (unknown [9.145.21.52]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 15 May 2019 17:24:20 +0000 (GMT) Date: Wed, 15 May 2019 19:23:44 +0200 From: Halil Pasic To: Michael Mueller Cc: pmorel@linux.ibm.com, kvm@vger.kernel.org, linux-s390@vger.kernel.org, Cornelia Huck , Martin Schwidefsky , Sebastian Ott , virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Christoph Hellwig , Thomas Huth , Christian Borntraeger , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman Subject: Re: [PATCH 10/10] virtio/s390: make airq summary indicators DMA In-Reply-To: <7c21b646-df27-88b6-6b06-3aab7887ff0a@linux.ibm.com> References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-11-pasic@linux.ibm.com> <74ff9a63-891a-7e24-0865-8cc91a95cada@linux.ibm.com> <7c21b646-df27-88b6-6b06-3aab7887ff0a@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 19051517-0016-0000-0000-0000027C1307 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19051517-0017-0000-0000-000032D8E4CC Message-Id: <20190515192344.5c57724c.pasic@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-15_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=763 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905150105 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 15 May 2019 15:33:02 +0200 Michael Mueller wrote: > >> @@ -273,8 +281,9 @@ static unsigned long get_airq_indicator(struct > >> virtqueue *vqs[], int nvqs, > >>       unsigned long bit, flags; > >>       for (i = 0; i < MAX_AIRQ_AREAS && !indicator_addr; i++) { > >> +        /* TODO: this seems to be racy */ > > > > yes, my opinions too, was already racy, in my opinion, we need another > > patch in another series to fix this. > > > > However, not sure about the comment. > > I will drop this comment for v2 of this patch series. > We shall fix the race with a separate patch. Unless there is somebody eager to address this real soon, I would prefer keeping the comment as a reminder. Thanks for shouldering the v2! Regards, Halil