From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH 4/4] KVM: nVMX: Fix using __this_cpu_read() in preemptible context
Date: Fri, 17 May 2019 13:12:41 -0700 [thread overview]
Message-ID: <20190517201241.GK15006@linux.intel.com> (raw)
In-Reply-To: <1558082990-7822-4-git-send-email-wanpengli@tencent.com>
On Fri, May 17, 2019 at 04:49:50PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> BUG: using __this_cpu_read() in preemptible [00000000] code: qemu-system-x86/4590
> caller is nested_vmx_enter_non_root_mode+0xebd/0x1790 [kvm_intel]
> CPU: 4 PID: 4590 Comm: qemu-system-x86 Tainted: G OE 5.1.0-rc4+ #1
> Call Trace:
> dump_stack+0x67/0x95
> __this_cpu_preempt_check+0xd2/0xe0
> nested_vmx_enter_non_root_mode+0xebd/0x1790 [kvm_intel]
> nested_vmx_run+0xda/0x2b0 [kvm_intel]
> handle_vmlaunch+0x13/0x20 [kvm_intel]
> vmx_handle_exit+0xbd/0x660 [kvm_intel]
> kvm_arch_vcpu_ioctl_run+0xa2c/0x1e50 [kvm]
> kvm_vcpu_ioctl+0x3ad/0x6d0 [kvm]
> do_vfs_ioctl+0xa5/0x6e0
> ksys_ioctl+0x6d/0x80
> __x64_sys_ioctl+0x1a/0x20
> do_syscall_64+0x6f/0x6c0
> entry_SYSCALL_64_after_hwframe+0x49/0xbe
>
> Accessing per-cpu variable should disable preemption, this patch extends the
> preemption disable region for __this_cpu_read().
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
Fixes: 52017608da33 ("KVM: nVMX: add option to perform early consistency checks via H/W")
and probably
Cc: stable@vger.kernel.org
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
next prev parent reply other threads:[~2019-05-17 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 8:49 [PATCH 1/4] KVM: x86: Disable intercept for CORE cstate read Wanpeng Li
2019-05-17 8:49 ` [PATCH RESEND 2/4] KVM: X86: Emulate MSR_IA32_MISC_ENABLE MWAIT bit Wanpeng Li
2019-05-20 10:34 ` Paolo Bonzini
2019-05-20 11:39 ` Wanpeng Li
2019-05-17 8:49 ` [PATCH 3/4] KVM: Fix spinlock taken warning during host resume Wanpeng Li
2019-05-20 10:36 ` Paolo Bonzini
2019-05-17 8:49 ` [PATCH 4/4] KVM: nVMX: Fix using __this_cpu_read() in preemptible context Wanpeng Li
2019-05-17 20:12 ` Sean Christopherson [this message]
2019-05-20 10:36 ` Paolo Bonzini
2019-05-20 10:30 ` [PATCH 1/4] KVM: x86: Disable intercept for CORE cstate read Paolo Bonzini
2019-05-20 11:29 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517201241.GK15006@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox