From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96027C04AAC for ; Mon, 20 May 2019 10:42:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A5422081C for ; Mon, 20 May 2019 10:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731469AbfETKmg convert rfc822-to-8bit (ORCPT ); Mon, 20 May 2019 06:42:36 -0400 Received: from 3.mo179.mail-out.ovh.net ([178.33.251.175]:37506 "EHLO 3.mo179.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730320AbfETKmg (ORCPT ); Mon, 20 May 2019 06:42:36 -0400 X-Greylist: delayed 3600 seconds by postgrey-1.27 at vger.kernel.org; Mon, 20 May 2019 06:42:35 EDT Received: from player795.ha.ovh.net (unknown [10.109.159.68]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id 1BB03131DC6 for ; Mon, 20 May 2019 11:23:50 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player795.ha.ovh.net (Postfix) with ESMTPSA id DCF8A5E0B299; Mon, 20 May 2019 09:23:43 +0000 (UTC) Date: Mon, 20 May 2019 11:23:43 +0200 From: Greg Kurz To: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Cc: kvm-ppc@vger.kernel.org, Paul Mackerras , David Gibson , kvm@vger.kernel.org, Satheesh Rajendran Subject: Re: [PATCH 3/3] KVM: PPC: Book3S HV: XIVE: fix the enforced limit on the vCPU identifier Message-ID: <20190520112343.7e724abb@bahia.lan> In-Reply-To: <20190520071514.9308-4-clg@kaod.org> References: <20190520071514.9308-1-clg@kaod.org> <20190520071514.9308-4-clg@kaod.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Ovh-Tracer-Id: 8225261772183607691 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddtkedgudehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 20 May 2019 09:15:14 +0200 Cédric Le Goater wrote: > When a vCPU is connected to the KVM device, it is done using its vCPU > identifier in the guest. Fix the enforced limit on the vCPU identifier > by taking into account the SMT mode. > Reviewed-by: Greg Kurz > Reported-by: Satheesh Rajendran > Tested-by: Satheesh Rajendran > Signed-off-by: Cédric Le Goater > --- > arch/powerpc/kvm/book3s_xive_native.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3s_xive_native.c b/arch/powerpc/kvm/book3s_xive_native.c > index 3fdea6bf4e97..25b6b0e2d02a 100644 > --- a/arch/powerpc/kvm/book3s_xive_native.c > +++ b/arch/powerpc/kvm/book3s_xive_native.c > @@ -109,7 +109,7 @@ int kvmppc_xive_native_connect_vcpu(struct kvm_device *dev, > return -EPERM; > if (vcpu->arch.irq_type != KVMPPC_IRQ_DEFAULT) > return -EBUSY; > - if (server_num >= KVM_MAX_VCPUS) { > + if (server_num >= (KVM_MAX_VCPUS * vcpu->kvm->arch.emul_smt_mode)) { > pr_devel("Out of bounds !\n"); > return -EINVAL; > }