Re: [PATCH 0/3] KVM: PPC: Book3S HV: XIVE: assorted fixes on vCPU and RAM limits

Greg Kurz
2019-05-23T14:00:57Z

[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]

On Thu, 23 May 2019 16:27:15 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Thu, May 23, 2019 at 08:01:23AM +0200, Greg Kurz wrote:
> > On Thu, 23 May 2019 09:30:43 +1000
> > David Gibson <david@gibson.dropbear.id.au> wrote:
> >
> > > On Mon, May 20, 2019 at 09:15:11AM +0200, Cédric Le Goater wrote:
> > > > Hello,
> > > >
> > > > Here are a couple of fixes for issues in the XIVE KVM device when
> > > > testing the limits : RAM size and number of vCPUS.
> > >
> > > How serious are the problems these patches fix? I'm wondering if I
> > > need to make a backport for RHEL8.1.
> > >
> >
> > Patch 2/3 fixes a QEMU error when hot-unplugging a vCPU:
> >
> > qemu-system-ppc64: KVM_SET_DEVICE_ATTR failed: Group 4 attr 0x0000000000000046: Invalid argument
> >
> >
> > Patch 3/3 fixes an issue where the guest freezes at some point when doing
> > vCPU hot-plug/unplug in a loop.
>
> Oh.. weird. It's not clear to me how it would do that.
>

Cedric provided a better description in some other mail: guest with 1024
vCPUs.

> > Both issues have a BZ at IBM. They can be mirrored to RH if needed.
>
> That would be helpful, thanks.
>

Ok, I'll take care of that.

>
>
>
> >
> > > >
> > > > Based on 5.2-rc1.
> > > >
> > > > Available on GitHub:
> > > >
> > > > https://github.com/legoater/linux/commits/xive-5.2
> > > >
> > > > Thanks,
> > > >
> > > > C.
> > > >
> > > > Cédric Le Goater (3):
> > > > KVM: PPC: Book3S HV: XIVE: clear file mapping when device is released
> > > > KVM: PPC: Book3S HV: XIVE: do not test the EQ flag validity when
> > > > reseting
> > > > KVM: PPC: Book3S HV: XIVE: fix the enforced limit on the vCPU
> > > > identifier
> > > >
> > > > arch/powerpc/kvm/book3s_xive_native.c | 46 ++++++++++++++++-----------
> > > > 1 file changed, 27 insertions(+), 19 deletions(-)
> > > >
> > >
> >
>
>
>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]