From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE30C04AB3 for ; Mon, 27 May 2019 12:10:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A6A5214D8 for ; Mon, 27 May 2019 12:10:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726304AbfE0MKk (ORCPT ); Mon, 27 May 2019 08:10:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54508 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbfE0MKk (ORCPT ); Mon, 27 May 2019 08:10:40 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC65881DF6; Mon, 27 May 2019 12:10:39 +0000 (UTC) Received: from gondolin (ovpn-204-109.brq.redhat.com [10.40.204.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3815A19C58; Mon, 27 May 2019 12:10:32 +0000 (UTC) Date: Mon, 27 May 2019 14:10:29 +0200 From: Cornelia Huck To: Halil Pasic Cc: Michael Mueller , KVM Mailing List , Linux-S390 Mailing List , Sebastian Ott , Heiko Carstens , virtualization@lists.linux-foundation.org, "Michael S . Tsirkin" , Christoph Hellwig , Thomas Huth , Christian Borntraeger , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman , Pierre Morel Subject: Re: [PATCH v2 6/8] virtio/s390: add indirection to indicators access Message-ID: <20190527141029.102f838a.cohuck@redhat.com> In-Reply-To: <20190527135706.34837062.pasic@linux.ibm.com> References: <20190523162209.9543-1-mimu@linux.ibm.com> <20190523162209.9543-7-mimu@linux.ibm.com> <20190527130028.62e1f7d7.cohuck@redhat.com> <20190527135706.34837062.pasic@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 27 May 2019 12:10:39 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 27 May 2019 13:57:06 +0200 Halil Pasic wrote: > On Mon, 27 May 2019 13:00:28 +0200 > Cornelia Huck wrote: > > > On Thu, 23 May 2019 18:22:07 +0200 > > Michael Mueller wrote: > > > > > From: Halil Pasic > > > > > > This will come in handy soon when we pull out the indicators from > > > virtio_ccw_device to a memory area that is shared with the hypervisor > > > (in particular for protected virtualization guests). > > > > > > Signed-off-by: Halil Pasic > > > Reviewed-by: Pierre Morel > > > --- > > > drivers/s390/virtio/virtio_ccw.c | 40 +++++++++++++++++++++++++--------------- > > > 1 file changed, 25 insertions(+), 15 deletions(-) > > > > > > > > @@ -338,17 +348,17 @@ static void virtio_ccw_drop_indicator(struct virtio_ccw_device *vcdev, > > > ccw->cda = (__u32)(unsigned long) thinint_area; > > > } else { > > > /* payload is the address of the indicators */ > > > - indicatorp = kmalloc(sizeof(&vcdev->indicators), > > > + indicatorp = kmalloc(sizeof(indicators(vcdev)), > > > GFP_DMA | GFP_KERNEL); > > > if (!indicatorp) > > > return; > > > *indicatorp = 0; > > > ccw->cmd_code = CCW_CMD_SET_IND; > > > - ccw->count = sizeof(&vcdev->indicators); > > > + ccw->count = sizeof(indicators(vcdev)); > > > ccw->cda = (__u32)(unsigned long) indicatorp; > > > } > > > /* Deregister indicators from host. */ > > > - vcdev->indicators = 0; > > > + *indicators(vcdev) = 0; > > > > I'm not too hot about this notation, but it's not wrong and a minor > > thing :) > > I don't have any better ideas :/ > > > > > > ccw->flags = 0; > > > ret = ccw_io_helper(vcdev, ccw, > > > vcdev->is_thinint ? > > > > Patch looks reasonable and not dependent on the other patches here. > > > > looks reasonable == r-b? > > Not dependent in a sense that this patch could be made a first patch in > the series. A subsequent patch depends on it. What is the plan with these patches? I can either pick patch 5+6 and let them go through the virtio tree, or give my r-b and let them go through the s390 tree. The former is probably the quicker route, but the latter has less potential for dependency issues.