From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 361EFC282CE for ; Tue, 4 Jun 2019 06:03:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09E2424A32 for ; Tue, 4 Jun 2019 06:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbfFDGDm (ORCPT ); Tue, 4 Jun 2019 02:03:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45810 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbfFDGDl (ORCPT ); Tue, 4 Jun 2019 02:03:41 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D76323086239; Tue, 4 Jun 2019 06:03:41 +0000 (UTC) Received: from gondolin (ovpn-116-92.ams2.redhat.com [10.36.116.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id 77CCC60C67; Tue, 4 Jun 2019 06:03:40 +0000 (UTC) Date: Tue, 4 Jun 2019 08:03:36 +0200 From: Cornelia Huck To: Farhan Ali Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, farman@linux.ibm.com, pasic@linux.ibm.com Subject: Re: [PATCH v1 1/1] vfio-ccw: Destroy kmem cache region on module exit Message-ID: <20190604080336.3b56c6d2.cohuck@redhat.com> In-Reply-To: References: Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 04 Jun 2019 06:03:41 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 3 Jun 2019 11:42:47 -0400 Farhan Ali wrote: > Free the vfio_ccw_cmd_region on module exit. > > Signed-off-by: Farhan Ali > --- > > I guess I missed this earlier while reviewing, but should'nt > we destroy the vfio_ccw_cmd_region on module exit, as well? > > drivers/s390/cio/vfio_ccw_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c > index 66a66ac..9cee9f2 100644 > --- a/drivers/s390/cio/vfio_ccw_drv.c > +++ b/drivers/s390/cio/vfio_ccw_drv.c > @@ -299,6 +299,7 @@ static void __exit vfio_ccw_sch_exit(void) > css_driver_unregister(&vfio_ccw_sch_driver); > isc_unregister(VFIO_CCW_ISC); > kmem_cache_destroy(vfio_ccw_io_region); > + kmem_cache_destroy(vfio_ccw_cmd_region); > destroy_workqueue(vfio_ccw_work_q); > } > module_init(vfio_ccw_sch_init); Yes, you're right. Will queue when the pull req has been processed.