From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E761C282CE for ; Tue, 4 Jun 2019 22:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3072B20665 for ; Tue, 4 Jun 2019 22:02:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sRROU3ZS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbfFDWC1 (ORCPT ); Tue, 4 Jun 2019 18:02:27 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:40993 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfFDWC1 (ORCPT ); Tue, 4 Jun 2019 18:02:27 -0400 Received: by mail-lf1-f66.google.com with SMTP id 136so6054674lfa.8 for ; Tue, 04 Jun 2019 15:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=+qR7k4fQsvJSOTG1+GHIY0O5I4zb3htSI7DgZU8DKKc=; b=sRROU3ZSewLXqSVidFLm/fEKDkR8E5oS1HQ86nZyUs756OHXX3z1X9FzYSBXWUvv2V 0UFaJFwOSJx48CvRbjYJpCDeBC5uNbFrq7m624xjYu4QBgiWibGr6zGkJ1iMnbEd8qiL k2EX09KIZXEef9Cxqv2XpGUT4KdlBn4CzKx8sOGbglCQqeTIs9kSVnVvz3KLYiVhjoce Qr+gy1lE+IAF0qBTeCLey9xIAvwkcU5z/+hzjTHqEZL0Ag+f6lNqzOvFsSPfxzB9lEjp G1tzBBWhBwY+O9aqKKKNmYqMRIKGLl1gycnbuTSTTlGxcWCtROpmWpN70hiPDfIvkPAq /wsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=+qR7k4fQsvJSOTG1+GHIY0O5I4zb3htSI7DgZU8DKKc=; b=NUhSbiruqocDm9cuX/2MrdQQpdiqLXEGCV0gwXQQpwpW4HMCsgKh7RFMObUhsPt3vN Xd4qeRo+VoZ+lJg8O//f7ZsmqGV9BhssXkBONuBerY/CFn/b2S/aTfeBJ5BkINtXJ6UR O7OBjSjnu3K0sCXBAbeowEiuYw3vfy8tZlxaRBRK7wkRZErXlQ4b5I6rwOyJQ1wqjkDB keCnQO49DtpjrwvlwMkA7MOD0BLpdCmG85Vbt1s1fXCIGjyT9yTDocMfGe3sy3ZTW9DN nTu37sJabB2f2k2DZiqKxIapWcRIJkyhnb3etGY54w/xGu/1We8qNlgUQnvh9HN3Vp7z HYQw== X-Gm-Message-State: APjAAAVRDb8+eUUErPJVg9wncSL5Jn8wG2lsEXuv+L+CJSiVV6g7H8ZX MnnNi3o/qVWjgCBC/X/DDlR4NmA/ X-Google-Smtp-Source: APXvYqw+3JnU75i5AXUmuQdnkXqHFSY9uRyQs+Wm9/x2Lr3fSh9thI6Lid64aLo835KgBLKd57CIZA== X-Received: by 2002:ac2:4ace:: with SMTP id m14mr11020656lfp.99.1559685744856; Tue, 04 Jun 2019 15:02:24 -0700 (PDT) Received: from dnote ([5.35.65.245]) by smtp.gmail.com with ESMTPSA id q2sm1675671lfj.25.2019.06.04.15.02.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Jun 2019 15:02:24 -0700 (PDT) Date: Wed, 5 Jun 2019 01:02:21 +0300 From: Eugene Korenevsky To: kvm@vger.kernel.org Cc: Paolo Bonzini Subject: [PATCH v2 1/2] kvm: vmx: fix limit checking in get_vmx_mem_address() Message-ID: <20190604220221.GA23558@dnote> Mail-Followup-To: Eugene Korenevsky , kvm@vger.kernel.org, Paolo Bonzini MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.12.0 (2019-05-25) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Intel SDM vol. 3, 5.3: The processor causes a general-protection exception (or, if the segment is SS, a stack-fault exception) any time an attempt is made to access the following addresses in a segment: - A byte at an offset greater than the effective limit - A word at an offset greater than the (effective-limit – 1) - A doubleword at an offset greater than the (effective-limit – 3) - A quadword at an offset greater than the (effective-limit – 7) Therefore, the generic limit checking error condition must be exn = off > limit + 1 - operand_len but not exn = off + operand_len > limit as for now. Signed-off-by: Eugene Korenevsky --- arch/x86/kvm/vmx/nested.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c index f1a69117ac0f..fef3d7031715 100644 --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -4115,7 +4115,7 @@ int get_vmx_mem_address(struct kvm_vcpu *vcpu, unsigned long exit_qualification, */ if (!(s.base == 0 && s.limit == 0xffffffff && ((s.type & 8) || !(s.type & 4)))) - exn = exn || (off + sizeof(u64) > s.limit); + exn = exn || (off > s.limit + 1 - sizeof(u64)); } if (exn) { kvm_queue_exception_e(vcpu, -- 2.21.0