From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Joerg Roedel" <joro@8bytes.org>,
kvm@vger.kernel.org, "Jim Mattson" <jmattson@google.com>
Subject: Re: [PATCH 2/5] KVM: VMX: Read cached VM-Exit reason to detect external interrupt
Date: Thu, 6 Jun 2019 07:09:07 -0700 [thread overview]
Message-ID: <20190606140906.GA23169@linux.intel.com> (raw)
In-Reply-To: <77943c3f-405e-9cab-7535-cbe9cb1fc89b@redhat.com>
On Thu, Jun 06, 2019 at 03:02:02PM +0200, Paolo Bonzini wrote:
> On 20/04/19 07:50, Sean Christopherson wrote:
> > Generic x86 code blindly invokes the dedicated external interrupt
> > handler blindly, i.e. vmx_handle_external_intr() is called on all
> > VM-Exits regardless of the actual exit type.
>
> That's *really* blindly. :) Rephrased to
Hmm, I must not have seen the first one.
> Generic x86 code invokes the kvm_x86_ops external interrupt handler
> on all VM-Exits regardless of the actual exit type.
>
> - unsigned long entry;
> - gate_desc *desc;
> + unsigned long entry;
>
> I'd rather keep the desc variable to simplify review (with "diff -b")
> and because the code is more readable that way. Unless you have a
> strong reason not to do so, I can do the change when applying.
No strong reason, I found the code to be more readable without it :-)
next prev parent reply other threads:[~2019-06-06 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 5:50 [PATCH 0/5] KVM: VMX: INTR, NMI and #MC cleanup Sean Christopherson
2019-04-20 5:50 ` [PATCH 1/5] KVM: VMX: Fix handling of #MC that occurs during VM-Entry Sean Christopherson
2019-06-06 12:57 ` Paolo Bonzini
2019-04-20 5:50 ` [PATCH 2/5] KVM: VMX: Read cached VM-Exit reason to detect external interrupt Sean Christopherson
2019-06-06 13:02 ` Paolo Bonzini
2019-06-06 14:09 ` Sean Christopherson [this message]
2019-04-20 5:50 ` [PATCH 3/5] KVM: VMX: Store the host kernel's IDT base in a global variable Sean Christopherson
2019-04-20 14:17 ` [RFC PATCH] KVM: VMX: host_idt_base can be static kbuild test robot
2019-04-20 5:50 ` [PATCH 4/5] KVM: x86: Move kvm_{before,after}_interrupt() calls to vendor code Sean Christopherson
2019-04-20 5:50 ` [PATCH 5/5] KVM: VMX: Handle NMIs, #MCs and async #PFs in common irqs-disabled fn Sean Christopherson
2019-06-06 13:20 ` Paolo Bonzini
2019-06-06 15:14 ` Sean Christopherson
2019-06-07 11:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606140906.GA23169@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox