From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F49C04AB5 for ; Thu, 6 Jun 2019 14:09:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E32720665 for ; Thu, 6 Jun 2019 14:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727234AbfFFOJI (ORCPT ); Thu, 6 Jun 2019 10:09:08 -0400 Received: from mga17.intel.com ([192.55.52.151]:21430 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfFFOJI (ORCPT ); Thu, 6 Jun 2019 10:09:08 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2019 07:09:08 -0700 X-ExtLoop1: 1 Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.36]) by orsmga002.jf.intel.com with ESMTP; 06 Jun 2019 07:09:07 -0700 Date: Thu, 6 Jun 2019 07:09:07 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Radim =?utf-8?B?S3LEjW3DocWZ?= , Joerg Roedel , kvm@vger.kernel.org, Jim Mattson Subject: Re: [PATCH 2/5] KVM: VMX: Read cached VM-Exit reason to detect external interrupt Message-ID: <20190606140906.GA23169@linux.intel.com> References: <20190420055059.16816-1-sean.j.christopherson@intel.com> <20190420055059.16816-3-sean.j.christopherson@intel.com> <77943c3f-405e-9cab-7535-cbe9cb1fc89b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77943c3f-405e-9cab-7535-cbe9cb1fc89b@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jun 06, 2019 at 03:02:02PM +0200, Paolo Bonzini wrote: > On 20/04/19 07:50, Sean Christopherson wrote: > > Generic x86 code blindly invokes the dedicated external interrupt > > handler blindly, i.e. vmx_handle_external_intr() is called on all > > VM-Exits regardless of the actual exit type. > > That's *really* blindly. :) Rephrased to Hmm, I must not have seen the first one. > Generic x86 code invokes the kvm_x86_ops external interrupt handler > on all VM-Exits regardless of the actual exit type. > > - unsigned long entry; > - gate_desc *desc; > + unsigned long entry; > > I'd rather keep the desc variable to simplify review (with "diff -b") > and because the code is more readable that way. Unless you have a > strong reason not to do so, I can do the change when applying. No strong reason, I found the code to be more readable without it :-)