Re: [PATCH v6 2/3] KVM: vmx: Emulate MSR IA32_UMWAIT_CONTROL

Tao Xu
2019-07-12T00:42:54Z

On 7/11/2019 9:25 PM, Paolo Bonzini wrote:
> On 21/06/19 07:57, Tao Xu wrote:
>> + if (guest_cpuid_has(vcpu, X86_FEATURE_WAITPKG))
>> + atomic_switch_umwait_control_msr(vmx);
>> +
>
> guest_cpuid_has is slow. Please replace it with a test on
> secondary_exec_controls_get(vmx).

Thank you paolo, I will improve it.

>
> Are you going to look into nested virtualization support? This should
> include only 1) allowing setting the enable bit in secondary execution
> controls, and passing it through in prepare_vmcs02_early; 2) reflecting
> the vmexit in nested_vmx_exit_reflected.
>

I will add nested support in next version.

> Thanks,
>
> Paolo
>