Re: [PATCH v3 4/5] Added build and install scripts

samcacc
2019-06-28T08:27:50Z

On 6/28/19 10:17 AM, Paolo Bonzini wrote:
> On 28/06/19 09:59, samcacc@amazon.com wrote:
>>> Surely if it's important to generate core dumps, it's not only important
>>> during installation, no?
>> Yep... missed this. I'll move it to run.sh right before alf-many is
>> invoked. It would be nice to not have to sudo but it seems the only
>> alternative is an envvar AFL_I_DONT_CARE_ABOUT_MISSING_CRASHES which
>> just ignores AFL's warning if your system isn't going to produce core
>> dumps (which will cause AFL to miss some crashes, as the name suggests).
>
> Can you do this only if /proc/sys/kernel/core_pattern starts with a pipe
> sign?
>

I think I'll just remove the `echo > ...core_pattern` step from both the
build.sh and run.sh scripts and instead document it as a setup step in
the README. This also sidesteps the sudo use.

- Sam

> Thanks,
>
> Paolo
>