From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B94C48BD7 for ; Thu, 27 Jun 2019 08:21:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A7A020656 for ; Thu, 27 Jun 2019 08:21:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726464AbfF0IVN (ORCPT ); Thu, 27 Jun 2019 04:21:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44988 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbfF0IVM (ORCPT ); Thu, 27 Jun 2019 04:21:12 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 91C0B309175F; Thu, 27 Jun 2019 08:21:12 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8A39660C4E; Thu, 27 Jun 2019 08:21:09 +0000 (UTC) Date: Thu, 27 Jun 2019 10:21:07 +0200 From: Cornelia Huck To: Kirti Wankhede Cc: Alex Williamson , , Subject: Re: [PATCH] mdev: Send uevents around parent device registration Message-ID: <20190627102107.3c7715d9.cohuck@redhat.com> In-Reply-To: References: <156155924767.11505.11457229921502145577.stgit@gimli.home> <1ea5c171-cd42-1c10-966e-1b82a27351d9@nvidia.com> <20190626120551.788fa5ed@x1.home> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 27 Jun 2019 08:21:12 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 27 Jun 2019 00:33:59 +0530 Kirti Wankhede wrote: > On 6/26/2019 11:35 PM, Alex Williamson wrote: > > On Wed, 26 Jun 2019 23:23:00 +0530 > > Kirti Wankhede wrote: > > > >> On 6/26/2019 7:57 PM, Alex Williamson wrote: > >>> This allows udev to trigger rules when a parent device is registered > >>> or unregistered from mdev. > >>> > >>> Signed-off-by: Alex Williamson > >>> --- > >>> drivers/vfio/mdev/mdev_core.c | 10 ++++++++-- > >>> 1 file changed, 8 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > >>> index ae23151442cb..ecec2a3b13cb 100644 > >>> --- a/drivers/vfio/mdev/mdev_core.c > >>> +++ b/drivers/vfio/mdev/mdev_core.c > >>> @@ -146,6 +146,8 @@ int mdev_register_device(struct device *dev, const struct mdev_parent_ops *ops) > >>> { > >>> int ret; > >>> struct mdev_parent *parent; > >>> + char *env_string = "MDEV_STATE=registered"; > >>> + char *envp[] = { env_string, NULL }; > >>> > >>> /* check for mandatory ops */ > >>> if (!ops || !ops->create || !ops->remove || !ops->supported_type_groups) > >>> @@ -196,7 +198,8 @@ int mdev_register_device(struct device *dev, const struct mdev_parent_ops *ops) > >>> list_add(&parent->next, &parent_list); > >>> mutex_unlock(&parent_list_lock); > >>> > >>> - dev_info(dev, "MDEV: Registered\n"); > >>> + kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, envp); > >>> + > >> > >> Its good to have udev event, but don't remove debug print from dmesg. > >> Same for unregister. > > > > Who consumes these? They seem noisy. Thanks, > > > > I don't think its noisy, its more of logging purpose. This is seen in > kernel log only when physical device is registered to mdev. Yes; but why do you want to log success? If you need to log it somewhere, wouldn't a trace event be a much better choice?