From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F1ABC48BD6 for ; Thu, 27 Jun 2019 12:26:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7DA6320828 for ; Thu, 27 Jun 2019 12:26:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726443AbfF0M0k (ORCPT ); Thu, 27 Jun 2019 08:26:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52658 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbfF0M0k (ORCPT ); Thu, 27 Jun 2019 08:26:40 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 27516CA36F; Thu, 27 Jun 2019 12:26:40 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53930196F8; Thu, 27 Jun 2019 12:26:28 +0000 (UTC) Date: Thu, 27 Jun 2019 14:26:26 +0200 From: Cornelia Huck To: Alex Williamson Cc: "kvm@vger.kernel.org" , Libvirt Devel , Kirti Wankhede , Erik Skultety , Pavel Hrdina , "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" , Sylvain Bauza , Christophe de Dinechin , Matthew Rosato Subject: Re: mdevctl: A shoestring mediated device management and persistence utility Message-ID: <20190627142626.415138da.cohuck@redhat.com> In-Reply-To: <20190626195350.2e9c81d3@x1.home> References: <20190523172001.41f386d8@x1.home> <20190625165251.609f6266@x1.home> <20190626115806.3435c45c.cohuck@redhat.com> <20190626083720.42a2b5d4@x1.home> <20190626195350.2e9c81d3@x1.home> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 27 Jun 2019 12:26:40 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 26 Jun 2019 19:53:50 -0600 Alex Williamson wrote: > On Wed, 26 Jun 2019 08:37:20 -0600 > Alex Williamson wrote: > > > On Wed, 26 Jun 2019 11:58:06 +0200 > > Cornelia Huck wrote: > > > > > On Tue, 25 Jun 2019 16:52:51 -0600 > > > Alex Williamson wrote: > > > > > > > Hi, > > > > > > > > Based on the discussions we've had, I've rewritten the bulk of > > > > mdevctl. I think it largely does everything we want now, modulo > > > > devices that will need some sort of 1:N values per key for > > > > configuration in the config file versus the 1:1 key:value setup we > > > > currently have (so don't consider the format final just yet). > > > > > > We might want to factor out that config format handling while we're > > > trying to finalize it. > > > > > > cc:ing Matt for his awareness. I'm currently not quite sure how to > > > handle those vfio-ap "write several values to an attribute one at a > > > time" requirements. Maybe 1:N key:value is the way to go; maybe we > > > need/want JSON or something like that. > > > > Maybe we should just do JSON for future flexibility. I assume there > > are lots of helpers that should make it easy even from a bash script. > > I'll look at that next. > > Done. Throw away any old mdev config files, we use JSON now. The code changes look quite straightforward, thanks. > The per > mdev config now looks like this: > > { > "mdev_type": "i915-GVTg_V4_8", > "start": "auto" > } > > My expectation, and what I've already pre-enabled support in set_key > and get_key functions, is that we'd use arrays for values, so we might > have: > > "new_key": ["value1", "value2"] > > set_key will automatically convert a comma separated list of values > into such an array, so I'm thinking this would be specified by the user > as: > > # mdevctl modify -u UUID --key=new_key --value=value1,value2 Looks sensible. For vfio-ap, we'd probably end up with something like the following: { "mdev_type": "vfio_ap-passthrough", "start": "auto", "assign_adapter": ["5", "6"], "assign_domain": ["4", "0xab"] } (following the Guest1 example in the kernel documentation) > > We should think about whether ordering is important and maybe > incorporate that into key naming conventions or come up with some > syntax for specifying startup blocks. Thanks, > > Alex Hm... { "foo": "1", "bar": "42", "baz": { "depends": ["foo", "bar"], "value": "plahh" } } Something like that?