From: Cornelia Huck <cohuck@redhat.com>
To: Farhan Ali <alifm@linux.ibm.com>
Cc: farman@linux.ibm.com, pasic@linux.ibm.com,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RFC v1 3/4] vfio-ccw: Set pa_nr to 0 if memory allocation fails for pa_iova_pfn
Date: Tue, 2 Jul 2019 10:45:50 +0200 [thread overview]
Message-ID: <20190702104550.7d2e7563.cohuck@redhat.com> (raw)
In-Reply-To: <19d813c58e0c45df3f23d8b1033e00b5ac5c7779.1561997809.git.alifm@linux.ibm.com>
On Mon, 1 Jul 2019 12:23:45 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:
> So we clean up correctly.
>
> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c
> index cab1be9..c5655de 100644
> --- a/drivers/s390/cio/vfio_ccw_cp.c
> +++ b/drivers/s390/cio/vfio_ccw_cp.c
> @@ -72,8 +72,10 @@ static int pfn_array_alloc(struct pfn_array *pa, u64 iova, unsigned int len)
> sizeof(*pa->pa_iova_pfn) +
> sizeof(*pa->pa_pfn),
> GFP_KERNEL);
> - if (unlikely(!pa->pa_iova_pfn))
> + if (unlikely(!pa->pa_iova_pfn)) {
> + pa->pa_nr = 0;
> return -ENOMEM;
> + }
> pa->pa_pfn = pa->pa_iova_pfn + pa->pa_nr;
>
> pa->pa_iova_pfn[0] = pa->pa_iova >> PAGE_SHIFT;
This looks like an older error -- can you give a Fixes: tag? (Yeah, I
know I sound like a broken record wrt that tag... :)
next prev parent reply other threads:[~2019-07-02 8:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 16:23 [RFC v1 0/4] Some vfio-ccw fixes Farhan Ali
2019-07-01 16:23 ` [RFC v1 1/4] vfio-ccw: Set orb.cmd.c64 before calling ccwchain_handle_ccw Farhan Ali
2019-07-02 8:26 ` Cornelia Huck
2019-07-02 13:56 ` Farhan Ali
2019-07-02 15:11 ` Eric Farman
2019-07-03 9:30 ` Cornelia Huck
2019-07-08 13:34 ` Farhan Ali
2019-07-01 16:23 ` [RFC v1 2/4] vfio-ccw: No need to call cp_free on an error in cp_init Farhan Ali
2019-07-02 8:42 ` Cornelia Huck
2019-07-02 13:58 ` Farhan Ali
2019-07-02 16:15 ` Eric Farman
2019-07-02 16:48 ` Farhan Ali
2019-07-01 16:23 ` [RFC v1 3/4] vfio-ccw: Set pa_nr to 0 if memory allocation fails for pa_iova_pfn Farhan Ali
2019-07-02 8:45 ` Cornelia Huck [this message]
2019-07-02 14:07 ` Farhan Ali
2019-07-02 16:24 ` Eric Farman
2019-07-01 16:23 ` [RFC v1 4/4] vfio-ccw: Don't call cp_free if we are processing a channel program Farhan Ali
2019-07-02 9:51 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702104550.7d2e7563.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox