From: Alex Williamson <alex.williamson@redhat.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <kwankhede@nvidia.com>, <linux-kernel@vger.kernel.org>,
<kvm@vger.kernel.org>
Subject: Re: [PATCH -next] sample/mdev/mbochs: remove set but not used variable 'mdev_state'
Date: Tue, 2 Jul 2019 12:02:17 -0600 [thread overview]
Message-ID: <20190702120217.51ca4dfa@x1.home> (raw)
In-Reply-To: <20190525135349.16488-1-yuehaibing@huawei.com>
On Sat, 25 May 2019 21:53:49 +0800
YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> samples/vfio-mdev/mbochs.c: In function mbochs_ioctl:
> samples/vfio-mdev/mbochs.c:1188:21: warning: variable mdev_state set but not used [-Wunused-but-set-variable]
>
> It's not used any more since commit 104c7405a64d ("vfio:
> add edid support to mbochs sample driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> samples/vfio-mdev/mbochs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c
> index b038aa9f5a70..ac5c8c17b1ff 100644
> --- a/samples/vfio-mdev/mbochs.c
> +++ b/samples/vfio-mdev/mbochs.c
> @@ -1185,9 +1185,6 @@ static long mbochs_ioctl(struct mdev_device *mdev, unsigned int cmd,
> {
> int ret = 0;
> unsigned long minsz, outsz;
> - struct mdev_state *mdev_state;
> -
> - mdev_state = mdev_get_drvdata(mdev);
>
> switch (cmd) {
> case VFIO_DEVICE_GET_INFO:
Applied to vfio next branch for 5.3. Thanks!
Alex
prev parent reply other threads:[~2019-07-02 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 13:53 [PATCH -next] sample/mdev/mbochs: remove set but not used variable 'mdev_state' YueHaibing
2019-07-02 18:02 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702120217.51ca4dfa@x1.home \
--to=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox