From: Sean Christopherson <sean.j.christopherson@intel.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] KVM: nVMX: add tracepoint for failed nested VM-Enter
Date: Wed, 10 Jul 2019 05:42:35 -0700 [thread overview]
Message-ID: <20190710124235.GA3712@linux.intel.com> (raw)
In-Reply-To: <20190709172402.2934-2-sean.j.christopherson@intel.com>
On Tue, Jul 09, 2019 at 10:24:01AM -0700, Sean Christopherson wrote:
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 6dd20e0ad2fa..3bfce3f507c7 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -950,9 +960,9 @@ static int nested_vmx_load_cr3(struct kvm_vcpu *vcpu, unsigned long cr3, bool ne
> u32 *entry_failure_code)
> {
> if (cr3 != kvm_read_cr3(vcpu) || (!nested_ept && pdptrs_changed(vcpu))) {
> - if (!nested_cr3_valid(vcpu, cr3)) {
> + if (CC(!nested_cr3_valid(vcpu, cr3))) {
> *entry_failure_code = ENTRY_FAIL_DEFAULT;
> - return -EINVAL;
> + return 1;
Gah, botched the rebase, I'll send a v3.
next prev parent reply other threads:[~2019-07-10 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 17:24 [PATCH v2 0/2] KVM: nVMX: add tracepoints for nested VM-Enter failures Sean Christopherson
2019-07-09 17:24 ` [PATCH v2 1/2] KVM: nVMX: add tracepoint for failed nested VM-Enter Sean Christopherson
2019-07-10 12:42 ` Sean Christopherson [this message]
2019-07-09 17:24 ` [PATCH v2 2/2] KVM: nVMX: trace nested VM-Enter failures detected by H/W Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710124235.GA3712@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).