From: Cornelia Huck <cohuck@redhat.com>
To: Farhan Ali <alifm@linux.ibm.com>
Cc: farman@linux.ibm.com, pasic@linux.ibm.com,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v3 5/5] vfio-ccw: Update documentation for csch/hsch
Date: Fri, 12 Jul 2019 13:30:06 +0200 [thread overview]
Message-ID: <20190712133006.23efcd0d.cohuck@redhat.com> (raw)
In-Reply-To: <7d977612c3f3152ffb950d77ae11b4b25c1e20c4.1562854091.git.alifm@linux.ibm.com>
On Thu, 11 Jul 2019 10:28:55 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:
> We now support CLEAR SUBCHANNEL and HALT SUBCHANNEL
> via ccw_cmd_region.
>
> Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions")
> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
> ---
> Documentation/s390/vfio-ccw.rst | 31 ++++++++++++++++++++++++++++---
> 1 file changed, 28 insertions(+), 3 deletions(-)
(...)
> +vfio-ccw cmd region
> +-------------------
> +
> +The vfio-ccw cmd region is used to accept asynchronous instructions
> +from userspace.
> +
Add :: and indent the structure so that we get proper formatting?
(Sorry about not noticing this last time; but I can add it while
applying if there are no other comments.)
> +#define VFIO_CCW_ASYNC_CMD_HSCH (1 << 0)
> +#define VFIO_CCW_ASYNC_CMD_CSCH (1 << 1)
> +struct ccw_cmd_region {
> + __u32 command;
> + __u32 ret_code;
> +} __packed;
> +
> +This region is exposed via region type VFIO_REGION_SUBTYPE_CCW_ASYNC_CMD.
> +
> +Currently, CLEAR SUBCHANNEL and HALT SUBCHANNEL use this region.
> +
Otherwise,
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-07-12 11:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:28 [PATCH v3 0/5] Some vfio-ccw fixes Farhan Ali
2019-07-11 14:28 ` [PATCH v3 1/5] vfio-ccw: Fix misleading comment when setting orb.cmd.c64 Farhan Ali
2019-07-11 20:30 ` Eric Farman
2019-07-11 14:28 ` [PATCH v3 2/5] vfio-ccw: Fix memory leak and don't call cp_free in cp_init Farhan Ali
2019-07-11 20:30 ` Eric Farman
2019-07-12 11:26 ` Cornelia Huck
2019-07-11 14:28 ` [PATCH v3 3/5] vfio-ccw: Set pa_nr to 0 if memory allocation fails for pa_iova_pfn Farhan Ali
2019-07-11 14:28 ` [PATCH v3 4/5] vfio-ccw: Don't call cp_free if we are processing a channel program Farhan Ali
2019-07-12 13:19 ` Eric Farman
2019-07-11 14:28 ` [PATCH v3 5/5] vfio-ccw: Update documentation for csch/hsch Farhan Ali
2019-07-12 11:30 ` Cornelia Huck [this message]
2019-07-12 13:27 ` Farhan Ali
2019-07-12 13:28 ` Eric Farman
2019-07-15 13:07 ` [PATCH v3 0/5] Some vfio-ccw fixes Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712133006.23efcd0d.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).